Re: [PATCH 3/8] audit: Implement audit_log_tty()

Stefan Berger
2018-05-30T19:46:57Z

On 05/29/2018 05:07 PM, Paul Moore wrote:
> On Thu, May 24, 2018 at 4:11 PM, Stefan Berger
> <stefanb@linux.vnet.ibm.com> wrote:
>>
>> +void audit_log_tty(struct audit_buffer *ab, struct task_struct *tsk)
>> +{
>> + struct tty_struct *tty = audit_get_tty(tsk);
>> +
>> + audit_log_format(ab, " tty=%s", tty ? tty_name(tty) : "(none)");
>> + audit_put_tty(tty);
>> +}
> Perhaps I missed it, but your IMA patches only ever call this to log
> current's tty, yes? If so, I would prefer if we dropped the
> task_struct argument and always had audit_log_tty() use current.

Done.

>