From: Daniel Baluta <daniel.baluta@nxp.com>
To: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"colin.king@canonical.com" <colin.king@canonical.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>,
"perex@perex.cz" <perex@perex.cz>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] ASoC: ak5558: make two structures static
Date: Wed, 6 Jun 2018 10:24:01 +0000 [thread overview]
Message-ID: <1528280640.1938.22.camel@nxp.com> (raw)
In-Reply-To: <20180606095719.30831-1-colin.king@canonical.com>
On Mi, 2018-06-06 at 10:57 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The structure ak5558_pm and soc_codec_dev_ak5558 are local to the
> source and do not need to be in global scope, so make them static.
> Also make soc_codec_dev_ak5558 static.
>
> Cleans up sparse warnings:
> warning: symbol 'ak5558_pm' was not declared. Should it be static?
> warning: symbol 'soc_codec_dev_ak5558' was not declared. Should it be
> static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
next prev parent reply other threads:[~2018-06-06 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 9:57 [PATCH] ASoC: ak5558: make two structures static Colin King
2018-06-06 10:24 ` Daniel Baluta [this message]
2018-06-18 12:00 ` Applied "ASoC: ak5558: make two structures static" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528280640.1938.22.camel@nxp.com \
--to=daniel.baluta@nxp.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox