Re: [PATCH v2] bitfield: fix *_encode_bits()

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2018-06-15 at 11:51 +0300, Andy Shevchenko wrote:
> On Fri, Jun 15, 2018 at 12:26 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > There's a bug in *_encode_bits() in using ~field_multiplier() for
> > the check whether or not the constant value fits into the field,
> > this is wrong and clearly ~field_mask() was intended. This was
> > triggering for me for both constant and non-constant values.
> > 
> > Additionally, make this case actually into an compile error.
> > Declaring the extern function that will never exist with just a
> > warning is pointless as then later we'll just get a link error.
> > 
> > While at it, also fix the indentation in those lines I'm touching.
> 
> I'm just wondering if we have test cases for that API.
> If not, perhaps it's a good time to start (perhaps extend test_bitmap.c)?

I guess. Do we have infrastructure to provoke & check compile errors
though?

johannes