From: Jerome Brunet <jbrunet@baylibre.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ASoC: es7241: add es7241 codec support
Date: Mon, 02 Jul 2018 12:15:03 +0200 [thread overview]
Message-ID: <1530526503.2900.144.camel@baylibre.com> (raw)
In-Reply-To: <20180702101222.GF18211@sirena.org.uk>
On Mon, 2018-07-02 at 11:12 +0100, Mark Brown wrote:
> On Sat, Jun 30, 2018 at 07:22:41PM +0200, Jerome Brunet wrote:
>
> > + switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
> > + case SND_SOC_DAIFMT_I2S:
> > + case SND_SOC_DAIFMT_LEFT_J:
> > + break;
>
> These two modes are not the same so either there should be some
> different handling to select between them or one shouldn't be supported.
>
> Otherwise this looks good.
Actually, the difference is provided with some pull-up/pull-down resistor.
There no way to set this up in SW, AFAIK.
So the driver shall accept both and trust we are not doing anything crazy
next prev parent reply other threads:[~2018-07-02 10:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 17:22 [PATCH v2 0/2] ASoC: add es7241 support Jerome Brunet
2018-06-30 17:22 ` [PATCH v2 1/2] ASoC: es7241: add dt-bindings documentation for the es7241 adc Jerome Brunet
2018-07-02 10:06 ` Mark Brown
2018-06-30 17:22 ` [PATCH v2 2/2] ASoC: es7241: add es7241 codec support Jerome Brunet
2018-07-02 10:12 ` Mark Brown
2018-07-02 10:15 ` Jerome Brunet [this message]
2018-07-02 10:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530526503.2900.144.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox