From: Janani Sankara Babu <jananis37@gmail.com>
To: gregkh@linuxfoundation.org
Cc: keescook@chromium.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Janani Sankara Babu <jananis37@gmail.com>
Subject: [PATCH] Staging:fwserial Move LINUX_VENDOR_ID to firewire.h
Date: Mon, 9 Jul 2018 11:52:30 -0400 [thread overview]
Message-ID: <1531151550-4918-1-git-send-email-jananis37@gmail.com> (raw)
This driver uses the same unregistered vendor id that the
firewire core does (0xd00d1e). Hence it is exposed as a
define in firewire.h.
Signed-off-by:Janani Sankara Babu <jananis37@gmail.com>
---
drivers/staging/fwserial/fwserial.c | 1 -
include/linux/firewire.h | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
index e8bfe55..f2966f2 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -21,0 +21,0 @@
#define be32_to_u64(hi, lo) ((u64)be32_to_cpu(hi) << 32 | be32_to_cpu(lo))
-#define LINUX_VENDOR_ID 0xd00d1eU /* same id used in card root directory */
#define FWSERIAL_VERSION 0x00e81cU /* must be unique within LINUX_VENDOR_ID */
/* configurable options */
diff --git a/include/linux/firewire.h b/include/linux/firewire.h
index aec8f30..62cdff1 100644
--- a/include/linux/firewire.h
+++ b/include/linux/firewire.h
@@ -66,2 +66,2 @@
#define CSR_MODEL 0x17
#define CSR_DIRECTORY_ID 0x20
+#define LINUX_VENDOR_ID 0xd00d1eU /* same id used in card root directory */
+
struct fw_csr_iterator {
const u32 *p;
const u32 *end;
--
1.9.1
next reply other threads:[~2018-07-09 6:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 15:52 Janani Sankara Babu [this message]
2018-07-09 7:01 ` [PATCH] Staging:fwserial Move LINUX_VENDOR_ID to firewire.h Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531151550-4918-1-git-send-email-jananis37@gmail.com \
--to=jananis37@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox