From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755066AbbCELL6 (ORCPT ); Thu, 5 Mar 2015 06:11:58 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:60802 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843AbbCELL4 (ORCPT ); Thu, 5 Mar 2015 06:11:56 -0500 From: Laurent Pinchart To: Sudeep Holla Cc: Felipe Balbi , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , Greg Kroah-Hartman Subject: Re: [PATCH v2] usb: isp1760: add peripheral/device controller chip id Date: Thu, 05 Mar 2015 13:12 +0200 Message-ID: <1531689.NQxRgbjGcc@avalon> User-Agent: KMail/4.14.3 (Linux/3.18.7-gentoo; KDE/4.14.3; x86_64; ; ) In-Reply-To: <54F73B2B.3050305@arm.com> References: <1424800422-25332-1-git-send-email-sudeep.holla@arm.com> <38531734.64FvIzp7Ky@avalon> <54F73B2B.3050305@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sudeep, On Wednesday 04 March 2015 17:04:43 Sudeep Holla wrote: > On 04/03/15 16:11, Laurent Pinchart wrote: > > Hi Sudeep, > > > On Wednesday 04 March 2015 15:56:12 Sudeep Holla wrote: > [...] > > >> Also I don't see any message on the host side. Let me know if there's > >> something wrong in my config or test commands. > > > > Looks like a driver bug to me, .udc_start() and .udc_stop() should use > > spin_(un)lock_irq(). Would you like to submit a patch ? I can also do it. > > Thanks for the quick response. Yes I can submit that as I do have the > patch already. Though it removes above dump for possible deadlock, it's > still not working. So I was not sure if that's the right fix. Anyways I > will post that patch and you can review :) > > BTW, if you see above the log also contains "g_mass_storage gadget: > userspace failed to provide iSerialNumber". Is this OK ? or is this the > reason for not seeing any activity on host side. That should be ok. To rule out the possible low-level issues, have you checked that the ISP1761 OC1_N/VBUS pin is properly connected to the VBUS power supply coming from the host ? -- Regards, Laurent Pinchart