public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: <hannah@marvell.com>
To: <dan.j.williams@intel.com>, <vkoul@kernel.org>,
	<dmaengine@vger.kernel.org>
Cc: <thomas.petazzoni@bootlin.com>, <linux-kernel@vger.kernel.org>,
	<nadavh@marvell.com>, <omrii@marvell.com>, <oferh@marvell.com>,
	<gregory.clement@bootlin.com>, Hanna Hawa <hannah@marvell.com>
Subject: [PATCH 4/5] dmaengine: mv_xor_v2: move unmap to before callback
Date: Tue, 17 Jul 2018 13:30:02 +0300	[thread overview]
Message-ID: <1531823403-3683-5-git-send-email-hannah@marvell.com> (raw)
In-Reply-To: <1531823403-3683-1-git-send-email-hannah@marvell.com>

From: Hanna Hawa <hannah@marvell.com>

Completion callback should happen after dma_descriptor_unmap() has
happened. This allow the cache invalidate to happen and ensure that
the data accessed by the upper layer is in memory that was from DMA
rather than stale data. On some architecture this is done by the
hardware, however we should make the code consistent to not cause
confusion.

Signed-off-by: Hanna Hawa <hannah@marvell.com>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 drivers/dma/mv_xor_v2.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
index 14e2a7a..d41d916 100644
--- a/drivers/dma/mv_xor_v2.c
+++ b/drivers/dma/mv_xor_v2.c
@@ -589,10 +589,9 @@ static void mv_xor_v2_tasklet(unsigned long data)
 			 */
 			dma_cookie_complete(&next_pending_sw_desc->async_tx);
 
+			dma_descriptor_unmap(&next_pending_sw_desc->async_tx);
 			dmaengine_desc_get_callback_invoke(
 					&next_pending_sw_desc->async_tx, NULL);
-
-			dma_descriptor_unmap(&next_pending_sw_desc->async_tx);
 		}
 
 		dma_run_dependencies(&next_pending_sw_desc->async_tx);
-- 
1.9.1


  parent reply	other threads:[~2018-07-17 10:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 10:29 [PATCH 0/5] dmaengine: mv_xor_v2: fixes and alignment for XOR-v2 driver hannah
2018-07-17 10:29 ` [PATCH 1/5] dmaengine: mv_xor_v2: explicitly freeup irq hannah
2018-07-17 10:30 ` [PATCH 2/5] dmaengine: mv_xor_v2: kill the tasklets upon exit hannah
2018-07-17 10:30 ` [PATCH 3/5] dmaengine: mv_xor_v2: convert callback to helper function hannah
2018-07-20  9:29   ` Vinod
2018-07-17 10:30 ` hannah [this message]
2018-07-17 10:30 ` [PATCH 5/5] dmaengine: mv_xor_v2: enable COMPILE_TEST hannah
2018-07-20  9:32 ` [PATCH 0/5] dmaengine: mv_xor_v2: fixes and alignment for XOR-v2 driver Vinod

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1531823403-3683-5-git-send-email-hannah@marvell.com \
    --to=hannah@marvell.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nadavh@marvell.com \
    --cc=oferh@marvell.com \
    --cc=omrii@marvell.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox