From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>, jarkko.sakkinen@linux.intel.com
Cc: jgg@ziepe.ca, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm: add support for partial reads
Date: Thu, 19 Jul 2018 13:27:29 -0700 [thread overview]
Message-ID: <1532032049.3061.1.camel@HansenPartnership.com> (raw)
In-Reply-To: <0b9f0bb5-6620-0499-6680-5ec595167f23@intel.com>
On Thu, 2018-07-19 at 13:12 -0700, Tadeusz Struk wrote:
> On 07/19/2018 12:52 PM, James Bottomley wrote:
> > The ABI break is the error case as I outlined above. We can't
> > assume everyone uses the current interface without getting an error
> > and one error and your hosed is a nasty failure case to change the
> > interface to.
>
> Well, if there is a broken application out there that doesn't work
> today it will not work after this change neither.
It doesn't have to be broken ... it could be using EFAULT to probe the
buffer size for instance. That's the point of not breaking the ABI:
you don't second guess what applications are doing.
James
next prev parent reply other threads:[~2018-07-19 20:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 15:52 [PATCH] tpm: add support for partial reads Tadeusz Struk
2018-07-19 15:55 ` Tadeusz Struk
2018-07-19 17:19 ` James Bottomley
2018-07-19 17:54 ` Tadeusz Struk
2018-07-19 18:47 ` James Bottomley
2018-07-19 19:05 ` Tadeusz Struk
2018-07-19 19:52 ` James Bottomley
2018-07-19 20:12 ` Tadeusz Struk
2018-07-19 20:27 ` James Bottomley [this message]
2018-07-19 21:01 ` Tadeusz Struk
2018-07-23 20:19 ` Jarkko Sakkinen
2018-07-23 20:53 ` Tadeusz Struk
2018-07-23 21:13 ` James Bottomley
2018-07-23 21:38 ` Tadeusz Struk
2018-07-23 21:56 ` Jason Gunthorpe
2018-07-23 22:00 ` Tadeusz Struk
2018-07-23 22:08 ` Jason Gunthorpe
2018-07-23 23:42 ` Tadeusz Struk
2018-07-24 2:05 ` Jason Gunthorpe
2018-07-23 21:48 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532032049.3061.1.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox