From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Linus Walleij <linus.walleij@linaro.org>,
Magnus <magnus.damm@gmail.com>, Simon <horms@verge.net.au>,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: sh-pfc: IPSRx and MOD_SELx should be set before GPSRx
Date: Thu, 17 Mar 2016 08:58:45 +0200 [thread overview]
Message-ID: <1532372.pY3qGGVVN1@avalon> (raw)
In-Reply-To: <8737rrfe1f.wl%kuninori.morimoto.gx@renesas.com>
Hi Morimoto-san,
Thank you for the patch.
On Wednesday 16 March 2016 00:48:11 Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Gen2 / Gen3 datasheet will have below note in next version.
> This patch follows this note.
>
> IPSRx and MOD_SELx registers shall be set before setting GPSRx
> registers in case that they need to be configured.
> MOD_SELx registers can be set either earlier or later than setting
> IPSRx registers.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/pinctrl/sh-pfc/sh_pfc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h
> b/drivers/pinctrl/sh-pfc/sh_pfc.h index 2b593fc..f174d61 100644
> --- a/drivers/pinctrl/sh-pfc/sh_pfc.h
> +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
> @@ -279,7 +279,7 @@ struct sh_pfc_soc_info {
> * - msel: Module selector
> */
> #define PINMUX_IPSR_MSEL(ipsr, fn, msel) \
> - PINMUX_DATA(fn##_MARK, FN_##msel, FN_##ipsr, FN_##fn)
> + PINMUX_DATA(fn##_MARK, FN_##msel, FN_##fn, FN_##ipsr)
>
> /*
> * Describe a pinmux configuration for a single-function pin with GPIO
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-03-17 16:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 0:46 [PATCH 0/2] pinctrl: sh-pfc: tidyup IPSR/MOD_SEL/GPSR settings order Kuninori Morimoto
2016-03-16 0:47 ` [PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug Kuninori Morimoto
2016-03-16 8:27 ` Geert Uytterhoeven
2016-03-17 0:30 ` Kuninori Morimoto
2016-03-17 7:34 ` Geert Uytterhoeven
2016-03-17 6:26 ` Laurent Pinchart
2016-03-18 0:37 ` Kuninori Morimoto
2016-03-16 0:48 ` [PATCH 2/2] pinctrl: sh-pfc: IPSRx and MOD_SELx should be set before GPSRx Kuninori Morimoto
2016-03-16 8:32 ` Geert Uytterhoeven
2016-03-17 0:23 ` Kuninori Morimoto
2016-03-17 6:58 ` Laurent Pinchart [this message]
2016-03-22 13:18 ` Linus Walleij
2016-03-22 14:30 ` Geert Uytterhoeven
2016-03-22 14:33 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532372.pY3qGGVVN1@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox