* [PATCH] xfs: substitute spaces with tabs
@ 2018-08-01 16:22 Thomas Bianchi
2018-08-01 23:19 ` Darrick J. Wong
2018-08-03 14:56 ` Bill O'Donnell
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Bianchi @ 2018-08-01 16:22 UTC (permalink / raw)
To: linux-xfs; +Cc: Thomas Bianchi, Darrick J. Wong, linux-kernel
Inside xfs_attr_shortform_list removes spaces at the beginnig of the line
and replaces with tabs.
Issue found by checkpatch.
ERROR: code indent should use tabs where possible
Signed-off-by: Thomas Bianchi <thomas.bianchi8@gmail.com>
---
fs/xfs/xfs_attr_list.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
index f9ca801..a580340 100644
--- a/fs/xfs/xfs_attr_list.c
+++ b/fs/xfs/xfs_attr_list.c
@@ -87,7 +87,7 @@
*/
if (context->bufsize == 0 ||
(XFS_ISRESET_CURSOR(cursor) &&
- (dp->i_afp->if_bytes + sf->hdr.count * 16) < context->bufsize)) {
+ (dp->i_afp->if_bytes + sf->hdr.count * 16) < context->bufsize)) {
for (i = 0, sfe = &sf->list[0]; i < sf->hdr.count; i++) {
context->put_listent(context,
sfe->flags,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] xfs: substitute spaces with tabs
2018-08-01 16:22 [PATCH] xfs: substitute spaces with tabs Thomas Bianchi
@ 2018-08-01 23:19 ` Darrick J. Wong
2018-08-03 14:56 ` Bill O'Donnell
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2018-08-01 23:19 UTC (permalink / raw)
To: Thomas Bianchi; +Cc: linux-xfs, linux-kernel
On Wed, Aug 01, 2018 at 06:22:25PM +0200, Thomas Bianchi wrote:
> Inside xfs_attr_shortform_list removes spaces at the beginnig of the line
> and replaces with tabs.
> Issue found by checkpatch.
>
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Thomas Bianchi <thomas.bianchi8@gmail.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_attr_list.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
> index f9ca801..a580340 100644
> --- a/fs/xfs/xfs_attr_list.c
> +++ b/fs/xfs/xfs_attr_list.c
> @@ -87,7 +87,7 @@
> */
> if (context->bufsize == 0 ||
> (XFS_ISRESET_CURSOR(cursor) &&
> - (dp->i_afp->if_bytes + sf->hdr.count * 16) < context->bufsize)) {
> + (dp->i_afp->if_bytes + sf->hdr.count * 16) < context->bufsize)) {
> for (i = 0, sfe = &sf->list[0]; i < sf->hdr.count; i++) {
> context->put_listent(context,
> sfe->flags,
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xfs: substitute spaces with tabs
2018-08-01 16:22 [PATCH] xfs: substitute spaces with tabs Thomas Bianchi
2018-08-01 23:19 ` Darrick J. Wong
@ 2018-08-03 14:56 ` Bill O'Donnell
1 sibling, 0 replies; 3+ messages in thread
From: Bill O'Donnell @ 2018-08-03 14:56 UTC (permalink / raw)
To: Thomas Bianchi; +Cc: linux-xfs, Darrick J. Wong, linux-kernel
On Wed, Aug 01, 2018 at 06:22:25PM +0200, Thomas Bianchi wrote:
> Inside xfs_attr_shortform_list removes spaces at the beginnig of the line
> and replaces with tabs.
> Issue found by checkpatch.
>
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Thomas Bianchi <thomas.bianchi8@gmail.com>
> ---
looks fine.
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> fs/xfs/xfs_attr_list.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
> index f9ca801..a580340 100644
> --- a/fs/xfs/xfs_attr_list.c
> +++ b/fs/xfs/xfs_attr_list.c
> @@ -87,7 +87,7 @@
> */
> if (context->bufsize == 0 ||
> (XFS_ISRESET_CURSOR(cursor) &&
> - (dp->i_afp->if_bytes + sf->hdr.count * 16) < context->bufsize)) {
> + (dp->i_afp->if_bytes + sf->hdr.count * 16) < context->bufsize)) {
> for (i = 0, sfe = &sf->list[0]; i < sf->hdr.count; i++) {
> context->put_listent(context,
> sfe->flags,
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-03 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-01 16:22 [PATCH] xfs: substitute spaces with tabs Thomas Bianchi
2018-08-01 23:19 ` Darrick J. Wong
2018-08-03 14:56 ` Bill O'Donnell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).