From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13847C46471 for ; Tue, 7 Aug 2018 03:01:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2E1621A12 for ; Tue, 7 Aug 2018 03:01:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2E1621A12 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729920AbeHGFNr (ORCPT ); Tue, 7 Aug 2018 01:13:47 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:61081 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725936AbeHGFNr (ORCPT ); Tue, 7 Aug 2018 01:13:47 -0400 X-UUID: d0bd3a53466742c8a17f1385090c29b8-20180807 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 2091634794; Tue, 07 Aug 2018 11:01:33 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 7 Aug 2018 11:01:31 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Tue, 7 Aug 2018 11:01:32 +0800 Message-ID: <1533610892.10818.10.camel@mtksdaap41> Subject: Re: [PATCH v3 06/13] drm/mediatek: add RGB color format support for RDMA From: CK Hu To: Stu Hsieh CC: Philipp Zabel , David Airlie , Matthias Brugger , , , , , Date: Tue, 7 Aug 2018 11:01:32 +0800 In-Reply-To: <1533556700-26525-7-git-send-email-stu.hsieh@mediatek.com> References: <1533556700-26525-1-git-send-email-stu.hsieh@mediatek.com> <1533556700-26525-7-git-send-email-stu.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Stu: On Mon, 2018-08-06 at 19:58 +0800, Stu Hsieh wrote: > This patch add RGB color format support for RDMA, > including RGB565, RGB888, RGBA8888 and ARGB8888. > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 41 ++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > index 08866550740f..ba72d392dc27 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > @@ -35,6 +35,8 @@ > #define DISP_REG_RDMA_SIZE_CON_0 0x0014 > #define DISP_REG_RDMA_SIZE_CON_1 0x0018 > #define DISP_REG_RDMA_TARGET_LINE 0x001c > +#define DISP_RDMA_MEM_CON 0x0024 > +#define MEM_MODE_INPUT_SWAP BIT(8) > #define DISP_RDMA_MEM_SRC_PITCH 0x002c > #define DISP_RDMA_MEM_GMC_SETTING_0 0x0030 > #define DISP_REG_RDMA_FIFO_CON 0x0040 > @@ -46,6 +48,11 @@ > > #define RDMA_MEM_GMC 0x40402020 > > +#define MEM_MODE_INPUT_FORMAT_RGB565 0x0 > +#define MEM_MODE_INPUT_FORMAT_RGB888 (0x001 << 4) > +#define MEM_MODE_INPUT_FORMAT_RGBA8888 (0x002 << 4) > +#define MEM_MODE_INPUT_FORMAT_ARGB8888 (0x003 << 4) > + > struct mtk_disp_rdma_data { > unsigned int fifo_size; > }; > @@ -144,12 +151,46 @@ static void mtk_rdma_config(struct mtk_ddp_comp *comp, unsigned int width, > writel(reg, comp->regs + DISP_REG_RDMA_FIFO_CON); > } > > +static unsigned int rdma_fmt_convert(struct mtk_disp_rdma *rdma, > + unsigned int fmt) > +{ > + switch (fmt) { > + default: > + case DRM_FORMAT_RGB565: > + return MEM_MODE_INPUT_FORMAT_RGB565; > + case DRM_FORMAT_BGR565: > + return MEM_MODE_INPUT_FORMAT_RGB565 | MEM_MODE_INPUT_SWAP; > + case DRM_FORMAT_RGB888: > + return MEM_MODE_INPUT_FORMAT_RGB888; > + case DRM_FORMAT_BGR888: > + return MEM_MODE_INPUT_FORMAT_RGB888 | MEM_MODE_INPUT_SWAP; > + case DRM_FORMAT_RGBX8888: > + case DRM_FORMAT_RGBA8888: > + return MEM_MODE_INPUT_FORMAT_ARGB8888; I think the alphabet order of the naming reflect the dram order for each color. Of course, big-endian and little-endian would result in reversed naming order. I could not understand why RDMA use ARGB8888 naming for DRM RGBA8888. If the typo is from data sheet, I could just accept this typo and give an explain in driver because I want to align driver with data sheet. Regards, CK > + case DRM_FORMAT_BGRX8888: > + case DRM_FORMAT_BGRA8888: > + return MEM_MODE_INPUT_FORMAT_ARGB8888 | MEM_MODE_INPUT_SWAP; > + case DRM_FORMAT_XRGB8888: > + case DRM_FORMAT_ARGB8888: > + return MEM_MODE_INPUT_FORMAT_RGBA8888; > + case DRM_FORMAT_XBGR8888: > + case DRM_FORMAT_ABGR8888: > + return MEM_MODE_INPUT_FORMAT_RGBA8888 | MEM_MODE_INPUT_SWAP; > + } > +} > + > static void mtk_rdma_layer_config(struct mtk_ddp_comp *comp, unsigned int idx, > struct mtk_plane_state *state) > { > + struct mtk_disp_rdma *rdma = comp_to_rdma(comp); > struct mtk_plane_pending_state *pending = &state->pending; > unsigned int addr = pending->addr; > unsigned int pitch = pending->pitch & 0xffff; > + unsigned int fmt = pending->format; > + unsigned int con; > + > + con = rdma_fmt_convert(rdma, fmt); > + writel_relaxed(con, comp->regs + DISP_RDMA_MEM_CON); > > writel_relaxed(addr, comp->regs + DISP_RDMA_MEM_START_ADDR); > writel_relaxed(pitch, comp->regs + DISP_RDMA_MEM_SRC_PITCH);