* [PATCH 1/3] dmaengine: fsldma: move spin_lock_bh to spin_lock in tasklet
@ 2018-08-17 13:00 Barry Song
2018-09-03 10:55 ` Vinod
0 siblings, 1 reply; 2+ messages in thread
From: Barry Song @ 2018-08-17 13:00 UTC (permalink / raw)
To: leoyang.li, zw, dan.j.williams, vkoul, linuxppc-dev, dmaengine,
linux-kernel
Cc: Barry Song
as you are already in a tasklet, it is unnecessary to call spin_lock_bh.
Signed-off-by: Barry Song <21cnbao@gmail.com>
---
drivers/dma/fsldma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 1117b51..9d360a3 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -987,7 +987,7 @@ static void dma_do_tasklet(unsigned long data)
chan_dbg(chan, "tasklet entry\n");
- spin_lock_bh(&chan->desc_lock);
+ spin_lock(&chan->desc_lock);
/* the hardware is now idle and ready for more */
chan->idle = true;
@@ -995,7 +995,7 @@ static void dma_do_tasklet(unsigned long data)
/* Run all cleanup for descriptors which have been completed */
fsldma_cleanup_descriptors(chan);
- spin_unlock_bh(&chan->desc_lock);
+ spin_unlock(&chan->desc_lock);
chan_dbg(chan, "tasklet exit\n");
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/3] dmaengine: fsldma: move spin_lock_bh to spin_lock in tasklet
2018-08-17 13:00 [PATCH 1/3] dmaengine: fsldma: move spin_lock_bh to spin_lock in tasklet Barry Song
@ 2018-09-03 10:55 ` Vinod
0 siblings, 0 replies; 2+ messages in thread
From: Vinod @ 2018-09-03 10:55 UTC (permalink / raw)
To: Barry Song
Cc: leoyang.li, zw, dan.j.williams, linuxppc-dev, dmaengine,
linux-kernel
On 17-08-18, 06:00, Barry Song wrote:
> as you are already in a tasklet, it is unnecessary to call spin_lock_bh.
Applied all, thanks
You may want to check you send-mail options, they patches were all over
my inbox and npot threaded
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-03 10:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-17 13:00 [PATCH 1/3] dmaengine: fsldma: move spin_lock_bh to spin_lock in tasklet Barry Song
2018-09-03 10:55 ` Vinod
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).