* [PATCH 3/3] dmaengine: at_xdmac: move spin_lock_bh to spin_lock in tasklet
@ 2018-08-17 13:03 Barry Song
2018-08-20 9:28 ` Ludovic Desroches
0 siblings, 1 reply; 2+ messages in thread
From: Barry Song @ 2018-08-17 13:03 UTC (permalink / raw)
To: ludovic.desroches, vkoul, dan.j.williams, linux-arm-kernel,
dmaengine, linux-kernel
Cc: Barry Song
as you are already in a tasklet, it is unnecessary to call spin_lock_bh.
Signed-off-by: Barry Song <21cnbao@gmail.com>
---
drivers/dma/at_xdmac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index 4bf7256..4e55768 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -1600,7 +1600,7 @@ static void at_xdmac_tasklet(unsigned long data)
if (atchan->status & AT_XDMAC_CIS_ROIS)
dev_err(chan2dev(&atchan->chan), "request overflow error!!!");
- spin_lock_bh(&atchan->lock);
+ spin_lock(&atchan->lock);
desc = list_first_entry(&atchan->xfers_list,
struct at_xdmac_desc,
xfer_node);
@@ -1610,7 +1610,7 @@ static void at_xdmac_tasklet(unsigned long data)
txd = &desc->tx_dma_desc;
at_xdmac_remove_xfer(atchan, desc);
- spin_unlock_bh(&atchan->lock);
+ spin_unlock(&atchan->lock);
if (!at_xdmac_chan_is_cyclic(atchan)) {
dma_cookie_complete(txd);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 3/3] dmaengine: at_xdmac: move spin_lock_bh to spin_lock in tasklet
2018-08-17 13:03 [PATCH 3/3] dmaengine: at_xdmac: move spin_lock_bh to spin_lock in tasklet Barry Song
@ 2018-08-20 9:28 ` Ludovic Desroches
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Desroches @ 2018-08-20 9:28 UTC (permalink / raw)
To: Barry Song
Cc: vkoul, dan.j.williams, linux-arm-kernel, dmaengine, linux-kernel
On Fri, Aug 17, 2018 at 06:03:43AM -0700, Barry Song wrote:
> as you are already in a tasklet, it is unnecessary to call spin_lock_bh.
>
> Signed-off-by: Barry Song <21cnbao@gmail.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Thanks
> ---
> drivers/dma/at_xdmac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index 4bf7256..4e55768 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -1600,7 +1600,7 @@ static void at_xdmac_tasklet(unsigned long data)
> if (atchan->status & AT_XDMAC_CIS_ROIS)
> dev_err(chan2dev(&atchan->chan), "request overflow error!!!");
>
> - spin_lock_bh(&atchan->lock);
> + spin_lock(&atchan->lock);
> desc = list_first_entry(&atchan->xfers_list,
> struct at_xdmac_desc,
> xfer_node);
> @@ -1610,7 +1610,7 @@ static void at_xdmac_tasklet(unsigned long data)
> txd = &desc->tx_dma_desc;
>
> at_xdmac_remove_xfer(atchan, desc);
> - spin_unlock_bh(&atchan->lock);
> + spin_unlock(&atchan->lock);
>
> if (!at_xdmac_chan_is_cyclic(atchan)) {
> dma_cookie_complete(txd);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-20 9:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-17 13:03 [PATCH 3/3] dmaengine: at_xdmac: move spin_lock_bh to spin_lock in tasklet Barry Song
2018-08-20 9:28 ` Ludovic Desroches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).