From: Masami Hiramatsu <mhiramat@kernel.org>
To: Shuah Khan <shuah@kernel.org>, Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 11/28] selftests/ftrace: Improve kprobe on module testcase to load/unload module
Date: Thu, 30 Aug 2018 23:17:38 +0900 [thread overview]
Message-ID: <153563865827.29700.17322388816487128350.stgit@devbox> (raw)
In-Reply-To: <153563834333.29700.11242968505215651399.stgit@devbox>
Improve kprobe events on module testcase to check module
load/unload with disabled/enabled events. This also change
the target module to trace_printk.ko, so it depends on
CONFIG_SAMPLE_TRACE_PRINTK=m.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
Changes in v3:
- Fix to remove ".ko" extention from modprobe argument.
---
tools/testing/selftests/ftrace/config | 4 ++
.../ftrace/test.d/kprobe/kprobe_module.tc | 35 ++++++++++++++++++--
2 files changed, 36 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/ftrace/config b/tools/testing/selftests/ftrace/config
index 07db5ab09cc7..32cf61b6bb54 100644
--- a/tools/testing/selftests/ftrace/config
+++ b/tools/testing/selftests/ftrace/config
@@ -7,3 +7,7 @@ CONFIG_HIST_TRIGGERS=y
CONFIG_PREEMPT_TRACER=y
CONFIG_IRQSOFF_TRACER=y
CONFIG_PREEMPTIRQ_DELAY_TEST=m
+CONFIG_MODULES=y
+CONFIG_MODULE_UNLOAD=y
+CONFIG_SAMPLES=y
+CONFIG_SAMPLE_TRACE_PRINTK=m
diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_module.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_module.tc
index ec6c5fffef1e..d861bd776c5e 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_module.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_module.tc
@@ -4,11 +4,18 @@
[ -f kprobe_events ] || exit_unsupported # this is configurable
+rmmod trace-printk ||:
+if ! modprobe trace-printk ; then
+ echo "No trace-printk sample module - please make CONFIG_SAMPLE_TRACE_PRINTK=
+m"
+ exit_unresolved;
+fi
+
+MOD=trace_printk
+FUNC=trace_printk_irq_work
+
:;: "Add an event on a module function without specifying event name" ;:
-MOD=`lsmod | head -n 2 | tail -n 1 | cut -f1 -d" "`
-FUNC=`grep -m 1 ".* t .*\\[$MOD\\]" /proc/kallsyms | xargs | cut -f3 -d" "`
-[ "x" != "x$MOD" -a "y" != "y$FUNC" ] || exit_unresolved
echo "p $MOD:$FUNC" > kprobe_events
PROBE_NAME=`echo $MOD:$FUNC | tr ".:" "_"`
test -d events/kprobes/p_${PROBE_NAME}_0 || exit_failure
@@ -22,3 +29,25 @@ test -d events/kprobes/event1 || exit_failure
echo "p:kprobes1/event1 $MOD:$FUNC" > kprobe_events
test -d events/kprobes1/event1 || exit_failure
+
+:;: "Remove target module, but event still be there" ;:
+if ! rmmod trace-printk ; then
+ echo "Failed to unload module - please enable CONFIG_MODULE_UNLOAD"
+ exit_unresolved;
+fi
+test -d events/kprobes1/event1
+
+:;: "Check posibility to defining events on unloaded module";:
+echo "p:event2 $MOD:$FUNC" >> kprobe_events
+
+:;: "Target is gone, but we can prepare for next time";:
+echo 1 > events/kprobes1/event1/enable
+
+:;: "Load module again, which means the event1 should be recorded";:
+modprobe trace-printk
+grep "event1:" trace
+
+:;: "Remove the module again and check the event is not locked"
+rmmod trace-printk
+echo 0 > events/kprobes1/event1/enable
+echo "-:kprobes1/event1" >> kprobe_events
next prev parent reply other threads:[~2018-08-30 14:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 14:12 [PATCH v3 00/28] selftests/ftrace: Improve ftracetest with coverage check Masami Hiramatsu
2018-08-30 14:12 ` [PATCH v3 01/28] selftests/ftrace: Add --stop-fail hidden option for debug Masami Hiramatsu
2018-08-30 14:13 ` [PATCH v3 02/28] selftests/ftrace: Add --console hidden option Masami Hiramatsu
2018-08-30 14:13 ` [PATCH v3 03/28] selftests/ftrace: Add case number prefix to logfile Masami Hiramatsu
2018-08-30 14:14 ` [PATCH v3 04/28] selftests/ftrace: More initialize features in initialize_ftrace Masami Hiramatsu
2018-08-30 14:14 ` [PATCH v3 05/28] selftests/ftrace: Add SPDX License Identifier to template Masami Hiramatsu
2018-08-30 14:15 ` [PATCH v3 06/28] selftests/ftrace: Cleanup ftrace after running test Masami Hiramatsu
2018-08-30 14:15 ` [PATCH v3 07/28] selftests/ftrace: Remove unneeded per-test init/cleanup ftrace Masami Hiramatsu
2018-08-30 14:16 ` [PATCH v3 08/28] selftests/ftrace: Fix to test kprobe $comm arg only if available Masami Hiramatsu
2018-08-30 14:16 ` [PATCH v3 09/28] selftests/ftrace: Fix checkbashisms errors Masami Hiramatsu
2018-08-30 14:17 ` [PATCH v3 10/28] selftests/ftrace: Use loopback address instead of localhost Masami Hiramatsu
2018-08-30 14:17 ` Masami Hiramatsu [this message]
2018-08-30 14:18 ` [PATCH v3 12/28] selftests/ftrace: Improve kprobe testcase to check log data Masami Hiramatsu
2018-08-30 14:18 ` [PATCH v3 13/28] selftests/ftrace: Improve kretprobe " Masami Hiramatsu
2018-08-30 14:19 ` [PATCH v3 14/28] selftests/ftrace: Test kprobe-event argument with various bitsize Masami Hiramatsu
2018-08-30 14:19 ` [PATCH v3 15/28] selftests/ftrace: Check set_event_pid result Masami Hiramatsu
2018-08-30 14:19 ` [PATCH v3 16/28] selftests/ftrace: Add kprobe event with $comm argument testcase Masami Hiramatsu
2018-08-30 14:20 ` [PATCH v3 17/28] selftests/ftrace: Add kprobe profile testcase Masami Hiramatsu
2018-08-30 14:20 ` [PATCH v3 18/28] selftests/ftrace: Add kprobe-event with symbol argument test Masami Hiramatsu
2018-08-30 14:21 ` [PATCH v3 19/28] selftests/ftrace: Add trace_printk sample module test Masami Hiramatsu
2018-08-30 14:21 ` [PATCH v3 20/28] selftests/ftrace: Add ringbuffer size changing testcase Masami Hiramatsu
2018-08-30 14:22 ` [PATCH v3 21/28] selftests/ftrace: Add function profiling stat testcase Masami Hiramatsu
2018-08-30 14:22 ` [PATCH v3 22/28] selftests/ftrace: Add max stack tracer testcase Masami Hiramatsu
2018-08-30 14:23 ` [PATCH v3 23/28] selftests/ftrace: Add function filter on module testcase Masami Hiramatsu
2018-08-30 14:23 ` [PATCH v3 24/28] selftests/ftrace: Add trace_pipe testcase Masami Hiramatsu
2018-08-30 14:24 ` [PATCH v3 25/28] selftests/ftrace: Add stacktrace ftrace filter command testcase Masami Hiramatsu
2018-08-30 14:24 ` [PATCH v3 26/28] selftests/ftrace: Add wakeup tracer testcase Masami Hiramatsu
2018-08-30 14:25 ` [PATCH v3 27/28] selftests/ftrace: Add wakeup_rt " Masami Hiramatsu
2018-08-30 14:25 ` [PATCH v3 28/28] selftests/ftrace: Add ftrace cpumask testcase Masami Hiramatsu
2018-09-12 9:57 ` [PATCH v3 00/28] selftests/ftrace: Improve ftracetest with coverage check Masami Hiramatsu
2018-09-21 21:24 ` Shuah Khan
2018-09-27 22:49 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153563865827.29700.17322388816487128350.stgit@devbox \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox