From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD476C6778D for ; Tue, 11 Sep 2018 10:20:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9957320867 for ; Tue, 11 Sep 2018 10:20:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="TOzE+prw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9957320867 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727753AbeIKPTO (ORCPT ); Tue, 11 Sep 2018 11:19:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:52394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726569AbeIKPTO (ORCPT ); Tue, 11 Sep 2018 11:19:14 -0400 Received: from localhost.localdomain (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AEC6320867; Tue, 11 Sep 2018 10:20:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1536661235; bh=Bv+IjdW7rEnDD4X/qdNrL+DbuzzcnjjbUAM8lQcz850=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TOzE+prw9S3pyv4V+M8wxzq3/hOEJss69oUQOG/hS3vtQROIN29oZfe/gGPRCKTiu UGaqeUeb53VKkSbfRcEDutOXtkALDRP3qQQTaudtEL1EakbswaVANDSC4BSPbh5lUC JYAIQqg5bACWJUpQJcclViF6IHx3RDKbTNPb8w/o= From: Masami Hiramatsu To: Ingo Molnar Cc: "Naveen N . Rao" , Anil S Keshavamurthy , "David S . Miller" , Masami Hiramatsu , linux-kernel@vger.kernel.org Subject: [PATCH -tip v2 3/5] kprobes: Remove meaningless BUG_ON from reuse_unused_kprobe Date: Tue, 11 Sep 2018 19:20:11 +0900 Message-Id: <153666121154.21306.17540752948574483565.stgit@devbox> X-Mailer: git-send-email 2.13.6 In-Reply-To: <153666112297.21306.4621579144717171778.stgit@devbox> References: <153666112297.21306.4621579144717171778.stgit@devbox> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since reuse_unused_kprobe is called when the given kprobe is unused, checking it inside again with BUG_ON is meaningless. Remove it. Signed-off-by: Masami Hiramatsu --- kernel/kprobes.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/kprobes.c b/kernel/kprobes.c index 231569e1e2c8..277a6cbe83db 100644 --- a/kernel/kprobes.c +++ b/kernel/kprobes.c @@ -704,7 +704,6 @@ static void reuse_unused_kprobe(struct kprobe *ap) { struct optimized_kprobe *op; - BUG_ON(!kprobe_unused(ap)); /* * Unused kprobe MUST be on the way of delayed unoptimizing (means * there is still a relative jump) and disabled.