Re: [PATCH 2/5] selinux: remove pointless cast in selinux_inode_setsecurity()

Paul Moore
2015-09-30T16:31:46Z

On Saturday, September 26, 2015 12:34:16 AM Rasmus Villemoes wrote:
> security_context_to_sid() expects a const char* argument, so there's
> no point in casting away the const qualifier of value.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied.

> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index fd50cd5ac2ec..5edb57df86f8 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3162,7 +3162,7 @@ static int selinux_inode_setsecurity(struct inode
> *inode, const char *name, if (!value || !size)
> return -EACCES;
>
> - rc = security_context_to_sid((void *)value, size, &newsid, GFP_KERNEL);
> + rc = security_context_to_sid(value, size, &newsid, GFP_KERNEL);
> if (rc)
> return rc;

--
paul moore