From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBotsoVOqn6kZpTCqOyKzpD7wDNNGvO0RAVP6shB20AoyaCu2d4bn+2V6cUmS/KwsxZTwmCzZ ARC-Seal: i=1; a=rsa-sha256; t=1516253546; cv=none; d=google.com; s=arc-20160816; b=PHbbzSwnZjpySHoASO1VSYuzDZCxO8aIwyK1qvqoBD6W8+cBc4QRhqpVwWl2vQD+8r ILP2RsKPxz1MKV6h4xZvxZVm+WC6S/JrWT9D47U1PTqFCZgCEKnUkrPZEbTVc8id8exr +bUK6mHJ/lJmqyM3BihGRPX9hT7qYiVgA/9VXgwCbKv1XqR92JEQvqOAWZElP1b3+8vW cU16eLM8IaUuUZ65XRFQX3zx+sFs5eRCA9bAMaBw9/WLmZfBPgROdW3aHUnlQ8mMSk3S IVkN7mE/ompXsURkY0NMw5/YESpV1bubXGYt2LoGRJjrPxWy05mHEmBlMLgKhiw+xQxL V59g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:message-id:references:in-reply-to:subject:cc:to:from :date:content-transfer-encoding:mime-version:dkim-signature :dkim-signature:arc-authentication-results; bh=2fncdh7dYZMQZ1TqcD36KDJdJtm06XdtCTjDWVVh7yA=; b=qczImj3/l6/eSk7A8GsW9tnjmAMz0JSBuiU+KXxX38xPbtmDdERRIp5BRug8lIbN4Z QDJaFvW7HPJ5EYnk9N4P225P7v0doXNkMFBpM1OFmiRIXxBBkgU3OqQYJB9b9qIFMkX1 LFG4DV+AHD5VoLolkve+D8TsesmcpWZCB9q33+nctNBAeqLLhfOarmP3GbOCLoN/ICtZ YkwS093Y9iyJcwN704IzJi67finiWPJeImme9rQFpHuN/wDOBPxa5Ok9MOtD5hPjULOy S02GAGJKqYAzYyBTw4OEd98SAf5UBxA3ZbuSv/ruikObSnVbVAsic6s+nI7oGHrJfIC6 P0XA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Rfox8/Wx; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ot38ZvjK; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Rfox8/Wx; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ot38ZvjK; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 18 Jan 2018 11:02:24 +0530 From: poza@codeaurora.org To: Keith Busch Cc: Sinan Kaya , Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Wei Zhang , Timur Tabi Subject: Re: [PATCH v5 4/4] PCI/DPC: Enumerate the devices after DPC trigger event In-Reply-To: <20180118025615.GF7562@localhost.localdomain> References: <1516185438-31556-1-git-send-email-poza@codeaurora.org> <1516185438-31556-5-git-send-email-poza@codeaurora.org> <20180118025615.GF7562@localhost.localdomain> Message-ID: <153733e36c151d2a549b814e4232c0df@codeaurora.org> User-Agent: Roundcube Webmail/1.2.5 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589835695085239135?= X-GMAIL-MSGID: =?utf-8?q?1589907078238498802?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 2018-01-18 08:26, Keith Busch wrote: > On Wed, Jan 17, 2018 at 08:27:39AM -0800, Sinan Kaya wrote: >> On 1/17/2018 5:37 AM, Oza Pawandeep wrote: >> > +static bool dpc_wait_link_active(struct pci_dev *pdev) >> > +{ >> >> I think you can also make this function common instead of making >> another copy here. >> Of course, this would be another patch. > > It is actually very similar to __pcie_wait_link_active in pciehp_hpc.c, > so there's some opprotunity to make even more common code. in that case there has to be a generic function in drives/pci.c which addresses folowing functions from pcie-dpc.c: dpc_wait_link_inactive dpc_wait_link_active drivers/pci/hotplug/pciehp_hpc.c pcie_wait_link_active all aboe making one generic function to be moved to drives/pci.c please let me know if this is okay. Regards, Oza.