From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86BC4C433F4 for ; Wed, 19 Sep 2018 10:11:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC5D2214C2 for ; Wed, 19 Sep 2018 10:11:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="QMig6hSZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC5D2214C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731110AbeISPsQ (ORCPT ); Wed, 19 Sep 2018 11:48:16 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:38891 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728008AbeISPsQ (ORCPT ); Wed, 19 Sep 2018 11:48:16 -0400 Received: by mail-wr1-f65.google.com with SMTP id j8-v6so1431049wrw.5 for ; Wed, 19 Sep 2018 03:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=teR9wf09S8jMA8BvDWdzSnircfBBjuVJ0vPkjT87Xsw=; b=QMig6hSZI/Iler+s4uvlZyvGdB0v3AopUhBc249p5f3eZz9VjkkN6IEqENmiukbids Y+AnBhDoe9zlJMeuXMsqwOgh+pH5JH1SN8E3n6eDkAUdv34SNT1fGdbFGZnyLLWZ/97K y5PwRYDFw8CJngSBuH25AhbWopTuwBu8t2gAj1ffKlxT4Q2LO9AONnvTOTqkYQkf9arS Kgv15ImrUSzxqV9nPFhidPSZFTuMMQ6RpLLN0zkHUbz/91D8zNq+e3IXmyaYdTECZ98u I62z8kmLHsp0YYrIHkWw/HMXGcj16Oa3QENC/0qVi3pqo/oRuAF+FA0sLOuxUW6j6pOD aMVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=teR9wf09S8jMA8BvDWdzSnircfBBjuVJ0vPkjT87Xsw=; b=re+A7SvV7/gYaDOPP98kDDwOVQVnaXKMRC6qYdC8aAsNDvwjaFLyhx1MrYEgfAwLH7 7Pn7yCmXHrfXIMoxoKLEwpCT3fV+zHd7CqhOGvjTSN3ggVP016cZLdUeFiN74OZpUSoJ KbX/WTfBaJVM+k3qQWvNVQUvF6cShGH2bIFgDKYYYwzNSeJYw+k453GuAuASVfnUpixK 88D0No8oiB2UTWjAYSZKTJ8bLeD75jyEkfxpljEO8JueJSBpVILCZsRNWW97DM0kfVmp y2nwTw2+E/sHHu639OlyIA3HERmQoWSR0AY12dTG4N1O2ylvXD4KPYHSp4p55FVs5UEO h+oA== X-Gm-Message-State: APzg51Af1ewvOykF0+HCdEAmpgLwf2eBd9B6ZlgaS+PNf5Z7iAF9tc1b PqTsp8k4kx4BeKZWJCSONMNgS5Ib5KY= X-Google-Smtp-Source: ANB0VdaoWon1El3AmHPD98bYYU86mwlnyiHFHuaikZIkVLNmTvoG7YxIBn8JReZoYH7yVIee2h//YQ== X-Received: by 2002:adf:8367:: with SMTP id 94-v6mr27359798wrd.258.1537351862588; Wed, 19 Sep 2018 03:11:02 -0700 (PDT) Received: from localhost.localdomain ([51.15.160.169]) by smtp.googlemail.com with ESMTPSA id q5-v6sm20488120wru.79.2018.09.19.03.11.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 19 Sep 2018 03:11:01 -0700 (PDT) From: Corentin Labbe To: davem@davemloft.net, herbert@gondor.apana.org.au, nhorman@tuxdriver.com Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH v3 0/2] crypto: Implement a generic crypto statistics Date: Wed, 19 Sep 2018 10:10:53 +0000 Message-Id: <1537351855-16618-1-git-send-email-clabbe@baylibre.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch is a try to implement a generic crypto driver statistics. The goal is to have an "ifconfig" for crypto device. Some driver tried to implement this via a debugfs interface. This serie do it directly in the crypto API and give access to stats via the crypto_user(netlink) API. Then an userspace tool will collect information via netlink. Note that this userspace tool is heavily copied from libkcapi and if Stephan Mueller agree, I will made a PR for adding getstat to it unless tools/crypto is the good place for it. Example of output: pkcs1pad(rsa-sun8i-ce,sha1) Akcipher Encrypt: 0 bytes: 0 Decrypt: 0 bytes: 0 Sign: 0 Verify: 5 Errors: 0 cryptd(__xts-aes-ce) cipher Encrypt: 0 bytes: 0 Decrypt: 0 bytes: 0 Errors: 0 xts-aes-ce cipher Encrypt: 17 bytes: 4384 Decrypt: 17 bytes: 4384 Errors: 0 cryptd(__ctr-aes-ce) cipher Encrypt: 0 bytes: 0 Decrypt: 0 bytes: 0 Errors: 0 ctr-aes-ce cipher Encrypt: 19 bytes: 5551 Decrypt: 19 bytes: 5551 Errors: 0 cryptd(__cbc-aes-ce) cipher Encrypt: 0 bytes: 0 Decrypt: 0 bytes: 0 Errors: 0 cbc-aes-ce cipher Encrypt: 19 bytes: 3040 Decrypt: 19 bytes: 3040 Errors: 0 cryptd(__ecb-aes-ce) cipher Encrypt: 0 bytes: 0 Decrypt: 0 bytes: 0 Errors: 0 ecb-aes-ce cipher Encrypt: 14 bytes: 2624 Decrypt: 14 bytes: 2624 Errors: 0 cbcmac-aes-ce Hash Hash: 20 bytes: 1244 Errors: 0 xcbc-aes-ce Hash Hash: 28 bytes: 543 Errors: 0 cmac-aes-ce Hash Hash: 36 bytes: 1472 Errors: 0 __xts-aes-ce cipher Encrypt: 17 bytes: 4384 Decrypt: 17 bytes: 4384 Errors: 0 ctr-aes-ce cipher Encrypt: 19 bytes: 5551 Decrypt: 19 bytes: 5551 Errors: 0 __ctr-aes-ce cipher Encrypt: 19 bytes: 5551 Decrypt: 19 bytes: 5551 Errors: 0 __cbc-aes-ce cipher Encrypt: 19 bytes: 3040 Decrypt: 19 bytes: 3040 Errors: 0 __ecb-aes-ce cipher Encrypt: 14 bytes: 2624 Decrypt: 14 bytes: 2624 Errors: 0 rsa-sun8i-ce Akcipher Encrypt: 7 bytes: 232 Decrypt: 6 bytes: 1152 Sign: 0 Verify: 5 Errors: 0 sun8i_ce_rng RNG Seed: 0 Generate: 0 bytes: 0 Errors: 0 ecb(des3_ede-generic) cipher Encrypt: 24 bytes: 4584 Decrypt: 24 bytes: 4584 Errors: 0 ecb-des3-sun8i-ce cipher Encrypt: 18 bytes: 3072 Decrypt: 18 bytes: 3072 Errors: 0 cbc(des3_ede-generic) cipher Encrypt: 14 bytes: 5104 Decrypt: 14 bytes: 5104 Errors: 0 aes-ce cipher Encrypt: 0 bytes: 0 Decrypt: 0 bytes: 0 Errors: 0 des3_ede-generic cipher Encrypt: 0 bytes: 0 Decrypt: 0 bytes: 0 Errors: 0 des-generic cipher Encrypt: 0 bytes: 0 Decrypt: 0 bytes: 0 Errors: 0 aes-arm64 cipher Encrypt: 0 bytes: 0 Decrypt: 0 bytes: 0 Errors: 0 crc32c-arm64-ce Hash Hash: 92 bytes: 20649 Errors: 0 cbc-des3-sun8i-ce cipher Encrypt: 10 bytes: 3488 Decrypt: 10 bytes: 3488 Errors: 0 crc32-arm64-ce Hash Hash: 92 bytes: 20649 Errors: 0 ecb-aes-sun8i-ce cipher Encrypt: 18 bytes: 3168 Decrypt: 18 bytes: 3168 Errors: 0 cbc-aes-sun8i-ce cipher Encrypt: 24 bytes: 3712 Decrypt: 24 bytes: 3712 Errors: 0 sha256-ce Hash Hash: 26 bytes: 8860 Errors: 0 sha224-ce Hash Hash: 26 bytes: 8860 Errors: 0 cts(cbc-aes-sun8i-ce) cipher Encrypt: 24 bytes: 956 Decrypt: 24 bytes: 956 Errors: 0 sha224-arm64-neon Hash Hash: 26 bytes: 8860 Errors: 0 sha256-arm64-neon Hash Hash: 26 bytes: 8860 Errors: 0 sha224-arm64 Hash Hash: 26 bytes: 8860 Errors: 0 sha256-arm64 Hash Hash: 26 bytes: 8860 Errors: 0 ctr-aes-sun8i-ce cipher Encrypt: 24 bytes: 6738 Decrypt: 24 bytes: 6738 Errors: 0 sha1-ce Hash Hash: 28 bytes: 9191 Errors: 0 ecdh-generic KPP Setsecret: 4 Generate public key: 3 Compute_shared_secret: 4 Errors: 0 ghash-generic Hash Hash: 32 bytes: 4358 Errors: 0 jitterentropy_rng RNG Seed: 0 Generate: 1 bytes: 48 Errors: 0 drbg_nopr_hmac_sha256 RNG Seed: 5 Generate: 9 bytes: 1056 Errors: 0 drbg_nopr_hmac_sha512 RNG Seed: 0 Generate: 0 bytes: 0 Errors: 0 drbg_nopr_hmac_sha384 RNG Seed: 0 Generate: 0 bytes: 0 Errors: 0 drbg_nopr_hmac_sha1 RNG Seed: 0 Generate: 0 bytes: 0 Errors: 0 drbg_pr_hmac_sha256 RNG Seed: 4 Generate: 8 bytes: 1024 Errors: 0 drbg_pr_hmac_sha512 RNG Seed: 0 Generate: 0 bytes: 0 Errors: 0 drbg_pr_hmac_sha384 RNG Seed: 0 Generate: 0 bytes: 0 Errors: 0 drbg_pr_hmac_sha1 RNG Seed: 0 Generate: 0 bytes: 0 Errors: 0 crct10dif-generic Hash Hash: 24 bytes: 19893 Errors: 0 crc32c-generic Hash Hash: 92 bytes: 20649 Errors: 0 aes-generic cipher Encrypt: 0 bytes: 0 Decrypt: 0 bytes: 0 Errors: 0 sha224-generic Hash Hash: 26 bytes: 8860 Errors: 0 sha256-generic Hash Hash: 26 bytes: 8860 Errors: 0 sha1-generic Hash Hash: 28 bytes: 9191 Errors: 0 digest_null-generic Hash Hash: 0 bytes: 0 Errors: 0 compress_null-generic Compress Compress: 0 bytes: 0 Decompress: 0 bytes: 0 Errors: 0 ecb-cipher_null cipher Encrypt: 0 bytes: 0 Decrypt: 0 bytes: 0 Errors: 0 cipher_null-generic cipher Encrypt: 0 bytes: 0 Decrypt: 0 bytes: 0 Errors: 0 rsa-generic Akcipher Encrypt: 17 bytes: 2832 Decrypt: 9 bytes: 1920 Sign: 0 Verify: 36 Errors: 0 Futur possible additions: - Add a "number of needed fallback" statistics. - statistics for maximum request size Please let me know your opinions about it Regards Changes since v2: - added documentation on new struct crypto_alg members. Changes since v1: - Do not use anymore CRYPTO_MSG_GETALG and added a dedicated CRYPTO_MSG_GETSTAT Changes since RFC: - Use cryptouser(netlink) instead of /sys - Use atomic_t instead of unsigned long - moved stat code into dedicated inline function - spelling fixes Corentin Labbe (2): crypto: Implement a generic crypto statistics crypto: tools: Add cryptostat userspace crypto/Kconfig | 11 + crypto/Makefile | 1 + crypto/ahash.c | 21 +- crypto/algapi.c | 8 + crypto/{crypto_user.c => crypto_user_base.c} | 9 +- crypto/crypto_user_stat.c | 463 +++++++++++++++++++++++++++ crypto/rng.c | 1 + include/crypto/acompress.h | 38 ++- include/crypto/aead.h | 51 ++- include/crypto/akcipher.h | 76 ++++- include/crypto/hash.h | 32 +- include/crypto/internal/cryptouser.h | 8 + include/crypto/kpp.h | 51 ++- include/crypto/rng.h | 29 +- include/crypto/skcipher.h | 44 ++- include/linux/crypto.h | 110 ++++++- include/uapi/linux/cryptouser.h | 52 +++ tools/crypto/getstat.c | 294 +++++++++++++++++ 18 files changed, 1264 insertions(+), 35 deletions(-) rename crypto/{crypto_user.c => crypto_user_base.c} (97%) create mode 100644 crypto/crypto_user_stat.c create mode 100644 include/crypto/internal/cryptouser.h create mode 100644 tools/crypto/getstat.c -- 2.16.4