From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7781DC433F4 for ; Fri, 21 Sep 2018 03:02:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1ADAA2087A for ; Fri, 21 Sep 2018 03:02:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1ADAA2087A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389065AbeIUIsv (ORCPT ); Fri, 21 Sep 2018 04:48:51 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:18575 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727252AbeIUIsu (ORCPT ); Fri, 21 Sep 2018 04:48:50 -0400 X-UUID: 1164864181304d9ab78c7e7b51694fda-20180921 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1433483404; Fri, 21 Sep 2018 11:02:03 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 21 Sep 2018 11:02:01 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Fri, 21 Sep 2018 11:02:02 +0800 Message-ID: <1537498922.17379.3.camel@mtksdaap41> Subject: Re: [PATCH v2 13/13] drm/mediatek: config component output by device node port From: Bibby Hsieh To: CK Hu CC: David Airlie , Matthias Brugger , Daniel Vetter , , , Yingjoe Chen , Cawa Cheng , Daniel Kurtz , "Philipp Zabel" , YT Shen , "Thierry Reding" , Mao Huang , , , "Sascha Hauer" Date: Fri, 21 Sep 2018 11:02:02 +0800 In-Reply-To: <1536213802.4618.41.camel@mtksdaap41> References: <20180905083146.14727-1-bibby.hsieh@mediatek.com> <20180905083146.14727-14-bibby.hsieh@mediatek.com> <1536213802.4618.41.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, CK, Thanks for the review comment. I will add the description in the binding document in v4. I want to send the other changes in v3 first. Thanks. Bibby On Thu, 2018-09-06 at 14:03 +0800, CK Hu wrote: > Hi, Bibby: > > On Wed, 2018-09-05 at 16:31 +0800, Bibby Hsieh wrote: > > We can select output component by decive node port. > > Main path default output component is DSI. > > External path default output component is DPI. > > > > Signed-off-by: Bibby Hsieh > > --- > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 37 ++++++++++++++++++++++++++++++---- > > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 4 ++-- > > 2 files changed, 35 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > index d961112fa2f5..a477fb878c06 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > @@ -21,7 +21,9 @@ > > #include > > #include > > #include > > +#include > > #include > > +#include > > #include > > #include > > > > @@ -133,7 +135,7 @@ static const struct drm_mode_config_funcs mtk_drm_mode_config_funcs = { > > .atomic_commit = mtk_atomic_commit, > > }; > > > > -static const enum mtk_ddp_comp_id mt2701_mtk_ddp_main[] = { > > +static enum mtk_ddp_comp_id mt2701_mtk_ddp_main[] = { > > DDP_COMPONENT_OVL0, > > DDP_COMPONENT_RDMA0, > > DDP_COMPONENT_COLOR0, > > @@ -141,7 +143,7 @@ static const enum mtk_ddp_comp_id mt2701_mtk_ddp_main[] = { > > DDP_COMPONENT_DSI0, > > }; > > > > -static const enum mtk_ddp_comp_id mt2701_mtk_ddp_ext[] = { > > +static enum mtk_ddp_comp_id mt2701_mtk_ddp_ext[] = { > > DDP_COMPONENT_RDMA1, > > DDP_COMPONENT_DPI0, > > }; > > @@ -172,7 +174,7 @@ static const enum mtk_ddp_comp_id mt2712_mtk_ddp_third[] = { > > DDP_COMPONENT_PWM2, > > }; > > > > -static const enum mtk_ddp_comp_id mt8173_mtk_ddp_main[] = { > > +static enum mtk_ddp_comp_id mt8173_mtk_ddp_main[] = { > > DDP_COMPONENT_OVL0, > > DDP_COMPONENT_COLOR0, > > DDP_COMPONENT_AAL0, > > @@ -183,7 +185,7 @@ static const enum mtk_ddp_comp_id mt8173_mtk_ddp_main[] = { > > DDP_COMPONENT_PWM0, > > }; > > > > -static const enum mtk_ddp_comp_id mt8173_mtk_ddp_ext[] = { > > +static enum mtk_ddp_comp_id mt8173_mtk_ddp_ext[] = { > > DDP_COMPONENT_OVL1, > > DDP_COMPONENT_COLOR1, > > DDP_COMPONENT_GAMMA, > > @@ -472,6 +474,7 @@ static int mtk_drm_probe(struct platform_device *pdev) > > > > /* Iterate over sibling DISP function blocks */ > > for_each_child_of_node(dev->of_node->parent, node) { > > + struct device_node *port, *ep, *remote; > > const struct of_device_id *of_id; > > enum mtk_ddp_comp_type comp_type; > > int comp_id; > > @@ -531,6 +534,32 @@ static int mtk_drm_probe(struct platform_device *pdev) > > > > private->ddp_comp[comp_id] = comp; > > } > > + > > + if (comp_type != MTK_DSI && comp_type != MTK_DPI) { > > + port = of_graph_get_port_by_id(node, 0); > > + if (!port) > > + continue; > > + ep = of_get_child_by_name(port, "endpoint"); > > + of_node_put(port); > > + if (!ep) > > + continue; > > + remote = of_graph_get_remote_port_parent(ep); > > + of_node_put(ep); > > + if (!remote) > > + continue; > > + of_id = of_match_node(mtk_ddp_comp_dt_ids, remote); > > + if (!of_id) > > + continue; > > + comp_type = (enum mtk_ddp_comp_type)of_id->data; > > + for (i = 0; i < private->data->main_len - 1; i++) > > + if (private->data->main_path[i] == comp_id) > > + private->data->main_path[i + 1] = > > + mtk_ddp_comp_get_id(node, comp_type); > > + for (i = 0; i < private->data->ext_len - 1; i++) > > + if (private->data->ext_path[i] == comp_id) > > + private->data->ext_path[i + 1] = > > + mtk_ddp_comp_get_id(node, comp_type); > > + } > > I think you should add description in binding document > (Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt) > for this. After the binding document is fully reviewed, we could start > to review this patch. > > Regards, > CK > > > } > > > > if (!private->mutex_node) { > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.h b/drivers/gpu/drm/mediatek/mtk_drm_drv.h > > index ecc00ca3221d..256a3ff2e66e 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.h > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.h > > @@ -29,9 +29,9 @@ struct drm_property; > > struct regmap; > > > > struct mtk_mmsys_driver_data { > > - const enum mtk_ddp_comp_id *main_path; > > + enum mtk_ddp_comp_id *main_path; > > unsigned int main_len; > > - const enum mtk_ddp_comp_id *ext_path; > > + enum mtk_ddp_comp_id *ext_path; > > unsigned int ext_len; > > const enum mtk_ddp_comp_id *third_path; > > unsigned int third_len; > > -- Bibby