From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C93EC04E87 for ; Fri, 28 Sep 2018 02:58:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D50E215E4 for ; Fri, 28 Sep 2018 02:58:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="lkhzDkDa"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="lkhzDkDa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D50E215E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728683AbeI1JTp (ORCPT ); Fri, 28 Sep 2018 05:19:45 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:41812 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726091AbeI1JTp (ORCPT ); Fri, 28 Sep 2018 05:19:45 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A3B3A600C1; Fri, 28 Sep 2018 02:58:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1538103495; bh=RCOF2X+A95ccqtXgFRdXQpNgpHTChgmew+X/52w81fY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lkhzDkDaIK+UDd9z7YyVb83prFwLnnvye2Xxn7QUWsY3/SQFmr4CoWdZqyDKusY+g a6hLx9E51eBSEy0aYtG0Pz1AtdwN4NPRuVVV6bJ7tj2CGENkLAdO7nfB5ko44tm5DK dH30Dp8WvVljeji9MzLKpevDB/SrNE26gbNXzRdE= Received: from jhugo-perf-lnx.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jhugo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4BA6C600C1; Fri, 28 Sep 2018 02:58:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1538103495; bh=RCOF2X+A95ccqtXgFRdXQpNgpHTChgmew+X/52w81fY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lkhzDkDaIK+UDd9z7YyVb83prFwLnnvye2Xxn7QUWsY3/SQFmr4CoWdZqyDKusY+g a6hLx9E51eBSEy0aYtG0Pz1AtdwN4NPRuVVV6bJ7tj2CGENkLAdO7nfB5ko44tm5DK dH30Dp8WvVljeji9MzLKpevDB/SrNE26gbNXzRdE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4BA6C600C1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=jhugo@codeaurora.org From: Jeffrey Hugo To: sudeep.holla@arm.com, gregkh@linuxfoundation.org, rjw@rjwysocki.net, linux-acpi@vger.kernel.org, jeremy.linton@arm.com Cc: linux-kernel@vger.kernel.org, vkilari@codeaurora.org, Jeffrey Hugo Subject: [PATCH v3 1/2] drivers: base: cacheinfo: Do not populate sysfs for unknown cache types Date: Thu, 27 Sep 2018 20:57:56 -0600 Message-Id: <1538103477-15513-2-git-send-email-jhugo@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1538103477-15513-1-git-send-email-jhugo@codeaurora.org> References: <1538103477-15513-1-git-send-email-jhugo@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If a cache has an unknown type because neither the hardware nor the firmware told us, an entry in the sysfs tree will be made, but the type file will not be present. lscpu depends on the type file being present for every entry, and will error out without printing system information if lscpu cannot open the type file. Presenting information about a cache without indicating its type is not useful, therefore if we hit a cache with an unknown type, stop populating sysfs so that userspace has the maximum amount of useful information. This addresses the following lscpu error, which prevents any output. lscpu: cannot open /sys/devices/system/cpu/cpu0/cache/index3/type: No such file or directory Suggested-by: Sudeep Holla Signed-off-by: Jeffrey Hugo Reviewed-by: Jeremy Linton --- drivers/base/cacheinfo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c index 5d5b598..cf78fa6 100644 --- a/drivers/base/cacheinfo.c +++ b/drivers/base/cacheinfo.c @@ -615,6 +615,8 @@ static int cache_add_dev(unsigned int cpu) this_leaf = this_cpu_ci->info_list + i; if (this_leaf->disable_sysfs) continue; + if (this_leaf->type == CACHE_TYPE_NOCACHE) + break; cache_groups = cache_get_attribute_groups(this_leaf); ci_dev = cpu_device_create(parent, this_leaf, cache_groups, "index%1u", i); -- Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.