From: Pkshih <pkshih@realtek.com>
To: "joe@perches.com" <joe@perches.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rickveens92@gmail.com" <rickveens92@gmail.com>,
"Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h
Date: Mon, 1 Oct 2018 09:01:46 +0000 [thread overview]
Message-ID: <1538384493.3117.1.camel@realtek.com> (raw)
In-Reply-To: <87in2ml2ts.fsf@kamboji.qca.qualcomm.com>
On Mon, 2018-10-01 at 07:15 +0300, Kalle Valo wrote:
> Joe Perches <joe@perches.com> writes:
>
> > On Sun, 2018-09-30 at 20:29 +0200, Rick Veens wrote:
> >> The following:
> >> bool efuse_re_pg_sec1flag;
> >> u8 efuse_re_pg_data[8];
> >> are not referenced anywhere in the rtlwifi code.
> >>
> >> Signed-off-by: Rick Veens <rickveens92@gmail.com>
> >> ---
> >> drivers/staging/rtlwifi/wifi.h | 4 ----
> >
> > Presumably the equivalent uses in
> > drivers/net/wireless/realtek/rtlwifi/wifi.h
> > should be removed as well.
>
> But if it's needed, just do it in separate patch as the patches go via
> different trees.
>
I can send this patch.
--
PK
prev parent reply other threads:[~2018-10-01 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-30 18:29 [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h Rick Veens
2018-09-30 18:35 ` Joe Perches
2018-10-01 4:15 ` Kalle Valo
2018-10-01 9:01 ` Pkshih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538384493.3117.1.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rickveens92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox