From: Tom Zanussi <zanussi@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Shuah Khan <shuah@kernel.org>
Cc: Rajvi Jingar <rajvi.jingar@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] tracing: Fix synthetic event parser
Date: Mon, 22 Oct 2018 15:14:53 -0500 [thread overview]
Message-ID: <1540239293.4393.6.camel@kernel.org> (raw)
In-Reply-To: <154013446976.25576.14780785912268176178.stgit@devbox>
Hi Masami,
On Mon, 2018-10-22 at 00:07 +0900, Masami Hiramatsu wrote:
> Hi,
>
> I found another bug in synthetic event. This is a small fix, but
> confusingly, there is also a bug in a test case.
>
> Steve, since the testcase bugfix ([2/2]) breaks the test result
> unless corresponding fix ([1/2]), I would like to ask you to send
> these fixes from your tree.
> Shuah, could you give this your ack?
>
Yes, I think the silent failing mode is confusing to users, and so
these changes make more sense.
Acked-by: Tom Zanussi <zanussi@linux.intel.com>
Tested-by: Tom Zanussi <zanussi@linux.intel.com>
Thanks,
Tom
> Thank you,
>
> ---
>
> Masami Hiramatsu (2):
> tracing: Return -ENOENT if there is no target synthetic event
> selftests/ftrace: Fix synthetic event test to delete event
> correctly
>
>
> kernel/trace/trace_events_hist.c | 4 +++-
> .../trigger-synthetic-event-createremove.tc | 12 ++++++--
> ----
> 2 files changed, 9 insertions(+), 7 deletions(-)
>
> --
> Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
next prev parent reply other threads:[~2018-10-22 20:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-21 15:07 [PATCH 0/2] tracing: Fix synthetic event parser Masami Hiramatsu
2018-10-21 15:08 ` [PATCH 1/2] tracing: Return -ENOENT if there is no target synthetic event Masami Hiramatsu
2018-10-21 15:08 ` [PATCH 2/2] selftests/ftrace: Fix synthetic event test to delete event correctly Masami Hiramatsu
2018-10-22 20:14 ` Tom Zanussi [this message]
2018-10-28 8:01 ` [PATCH 0/2] tracing: Fix synthetic event parser Steven Rostedt
2018-10-28 8:09 ` Steven Rostedt
2018-10-28 18:10 ` Shuah Khan
2018-10-28 19:13 ` Steven Rostedt
2018-10-28 17:33 ` Shuah Khan
2018-10-28 18:07 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540239293.4393.6.camel@kernel.org \
--to=zanussi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rajvi.jingar@intel.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox