public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: "Zengtao (B)" <prime.zeng@hisilicon.com>,
	"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>
Cc: "usb-storage@lists.one-eyed-alien.net" 
	<usb-storage@lists.one-eyed-alien.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: scsi_set_medium_removal timeout issue
Date: Tue, 30 Oct 2018 09:56:26 +0100	[thread overview]
Message-ID: <1540889786.12349.9.camel@suse.com> (raw)
In-Reply-To: <678F3D1BB717D949B966B68EAEB446ED1F19F1CF@dggemm526-mbx.china.huawei.com>

On Di, 2018-10-30 at 08:28 +0000,  Zengtao (B)  wrote:
> Hi 

> For the issue itself, there is my observation:
> In the step 4, the Host will issue an PREVENT_ALLOW_MEDIUM_REMOVAL scsi command.
> and and timeout happens due to the device 's very slow fsg_lun_fsync_sub.
> I found there are two methods to workaround the issue: 
> 1. Change the timeout value of host scsi command PREVENT_ALLOW_MEDIUM_REMOVAL to
> to about 60 seconds from 10 seconds.

That is near useless, because the gadget can be used with other
systems.

> 2. Remove the fsg_lun_fsync_sub in the device's Mass storage gadget driver.

It exists for a reason. The blocks have to be on the medium.
It seems to me that your gadget just allows too many dirty pages in the
cache.

	Regards
		Oliver


  reply	other threads:[~2018-10-30  8:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30  8:28 scsi_set_medium_removal timeout issue Zengtao (B)
2018-10-30  8:56 ` Oliver Neukum [this message]
2018-10-30  9:24   ` Zengtao (B)
2018-10-30 14:08 ` Alan Stern
2018-10-31  2:34   ` Zengtao (B)
2018-10-31 14:19     ` Alan Stern
2018-11-12 11:56       ` Zengtao (B)
2018-11-12 15:33         ` Alan Stern
2018-11-14  2:46           ` Zengtao (B)
2018-11-14 15:35             ` Alan Stern
2018-11-29  3:13               ` Zengtao (B)
2018-12-04 16:36                 ` Alan Stern
2019-04-01 20:27                   ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1540889786.12349.9.camel@suse.com \
    --to=oneukum@suse.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=prime.zeng@hisilicon.com \
    --cc=stern@rowland.harvard.edu \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox