Re: [PATCH 15/25] sched/vtime: Introduce vtime_accounting_enabled_cpu()

Peter Zijlstra
2018-11-20T14:05:22Z

On Wed, Nov 14, 2018 at 03:45:59AM +0100, Frederic Weisbecker wrote:
> This allows us to check if a remote CPU runs vtime accounting
> (ie: is nohz_full). We'll need that to reliably support "nice"
> accounting on kcpustat.
>
> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> Cc: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Wanpeng Li <wanpengli@tencent.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> ---
> include/linux/vtime.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/include/linux/vtime.h b/include/linux/vtime.h
> index 82fed7a..a53f6ea 100644
> --- a/include/linux/vtime.h
> +++ b/include/linux/vtime.h
> @@ -31,6 +31,16 @@ static inline bool vtime_accounting_enabled(void)
> return context_tracking_enabled();
> }
>
> +static inline bool vtime_accounting_enabled_cpu(int cpu)
> +{
> + if (vtime_accounting_enabled()) {
> + if (context_tracking_enabled_cpu(cpu))
> + return true;
> + }
> +
> + return false;
> +}

static inline bool vtime_account_enabled_cpu(int cpu)
{
return vtime_account_enabled() && context_tracking_enabled_cpu(cpu);
}

Hmm?