From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C19F0C43441 for ; Thu, 15 Nov 2018 15:34:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91460223CB for ; Thu, 15 Nov 2018 15:34:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91460223CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388507AbeKPBnI (ORCPT ); Thu, 15 Nov 2018 20:43:08 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:52309 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726432AbeKPBnI (ORCPT ); Thu, 15 Nov 2018 20:43:08 -0500 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1gNJfM-0000DB-2A; Thu, 15 Nov 2018 16:34:48 +0100 Message-ID: <1542296087.4915.28.camel@pengutronix.de> Subject: Re: [PATCHv4] reset: socfpga: add an early reset driver for SoCFPGA From: Philipp Zabel To: Dinh Nguyen Cc: linux-kernel@vger.kernel.org Date: Thu, 15 Nov 2018 16:34:47 +0100 In-Reply-To: <20181113185048.8538-1-dinguyen@kernel.org> References: <20181113185048.8538-1-dinguyen@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dinh, On Tue, 2018-11-13 at 12:50 -0600, Dinh Nguyen wrote: > @@ -120,7 +120,8 @@ static const struct reset_simple_devdata reset_simple_active_low = { > }; > > static const struct of_device_id reset_simple_dt_ids[] = { > - { .compatible = "altr,rst-mgr", .data = &reset_simple_socfpga }, > + { .compatible = "altr,stratix10-rst-mgr", "altr,rst-mgr", This should be +       { .compatible = "altr,stratix10-rst-mgr", instead. The rest looks good to me. If you are ok with this change, I can fix it up when applying. regards Philipp