From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751828AbdITGjD (ORCPT ); Wed, 20 Sep 2017 02:39:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52856 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510AbdITGjB (ORCPT ); Wed, 20 Sep 2017 02:39:01 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 69CEB4E34A Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=shuwang@redhat.com Date: Wed, 20 Sep 2017 02:39:01 -0400 (EDT) From: Shu Wang To: Greg KH Cc: yamada masahiro , mmarek@suse.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, chuhu@redhat.com, yizhan@redhat.com Message-ID: <1542341479.7952083.1505889541234.JavaMail.zimbra@redhat.com> In-Reply-To: <20170920061012.GA32032@kroah.com> References: <20170920023529.10881-1-shuwang@redhat.com> <20170920061012.GA32032@kroah.com> Subject: Re: [PATCH] kbuild/mkspec: remove firmware from rpm package MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.66.12.134, 10.4.195.25] Thread-Topic: kbuild/mkspec: remove firmware from rpm package Thread-Index: FGGh20mF4mXbLpqOEreIHs/+n4n9OQ== X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 20 Sep 2017 06:39:01 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Do you mean the patch for deb package? The patch didn't fix rpm package. or there's another patch I didn't get on the mailing list. https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1492398.html Thanks ----- Original Message ----- > From: "Greg KH" > To: shuwang@redhat.com > Cc: "yamada masahiro" , mmarek@suse.com, linux-kbuild@vger.kernel.org, > linux-kernel@vger.kernel.org, chuhu@redhat.com, yizhan@redhat.com > Sent: Wednesday, September 20, 2017 2:10:12 PM > Subject: Re: [PATCH] kbuild/mkspec: remove firmware from rpm package > > On Wed, Sep 20, 2017 at 10:35:29AM +0800, shuwang@redhat.com wrote: > > From: Shu Wang > > > > Commit 5620a0d1aacd ("firmware: delete in-kernel firmware") deleted > > in-kernel firmware support, including the firmware install command. > > > > So make binrpm-pkg will failed as no firmware_install make target. > > > > Signed-off-by: Shu Wang > > --- > > scripts/package/mkspec | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/scripts/package/mkspec b/scripts/package/mkspec > > index bb43f153fd8e..8f34e31d8474 100755 > > --- a/scripts/package/mkspec > > +++ b/scripts/package/mkspec > > @@ -88,11 +88,8 @@ echo 'mkdir -p $RPM_BUILD_ROOT/boot/efi > > $RPM_BUILD_ROOT/lib/modules' > > echo "%else" > > echo 'mkdir -p $RPM_BUILD_ROOT/boot $RPM_BUILD_ROOT/lib/modules' > > echo "%endif" > > -echo 'mkdir -p $RPM_BUILD_ROOT'"/lib/firmware/$KERNELRELEASE" > > > > echo 'INSTALL_MOD_PATH=$RPM_BUILD_ROOT make %{?_smp_mflags} KBUILD_SRC= > > mod-fw= modules_install' > > -echo 'INSTALL_FW_PATH=$RPM_BUILD_ROOT'"/lib/firmware/$KERNELRELEASE" > > -echo 'make INSTALL_FW_PATH=$INSTALL_FW_PATH' firmware_install > > echo "%ifarch ia64" > > echo 'cp $KBUILD_IMAGE $RPM_BUILD_ROOT'"/boot/efi/vmlinuz-$KERNELRELEASE" > > echo 'ln -s '"efi/vmlinuz-$KERNELRELEASE" '$RPM_BUILD_ROOT'"/boot/" > > @@ -154,7 +151,6 @@ echo '%defattr (-, root, root)' > > echo "/lib/modules/$KERNELRELEASE" > > echo "%exclude /lib/modules/$KERNELRELEASE/build" > > echo "%exclude /lib/modules/$KERNELRELEASE/source" > > -echo "/lib/firmware/$KERNELRELEASE" > > echo "/boot/*" > > echo "" > > echo "%files headers" > > I think this has already been posted to the list, right? > > Sorry about it, it's pretty obvious that no build system tests kernel > packages, and neither do I :) > > thanks, > > greg k-h >