Re: [PATCH 3/5] mm, memory_hotplug: drop pointless block alignment checks from __offline_pages

Michal Hocko
2018-11-16T11:19:59Z

On Fri 16-11-18 11:34:03, Oscar Salvador wrote:
> On Fri, 2018-11-16 at 09:30 +0100, Michal Hocko wrote:
> > From: Michal Hocko <mhocko@suse.com>
> >
> > This function is never called from a context which would provide
> > misaligned pfn range so drop the pointless check.
> >
> > Signed-off-by: Michal Hocko <mhocko@suse.com>
>
> I vaguely remember that someone reported a problem about misaligned
> range on powerpc.
> Not sure at which stage was (online/offline).
> Although I am not sure if that was valid at all.

If we are talking about the same thing then this was about partial
memblock initialized (aka struct pages were not initialized).

> Reviewed-by: Oscar Salvador <osalvador@suse.de>

Thanks!

--
Michal Hocko
SUSE Labs