Re: [BUG] symlink problem with knfsd and reiserfs

[Nikita Danilov <Nikita@Namesys.COM>]

Trond Myklebust writes:
 > >>>>> " " == Hans-Peter Jansen <hpj@urpla.net> writes:
 > 
 >      > In syslog, this message appears: Jan 15 00:21:03 elfe kernel:
 >      > nfs_refresh_inode: inode 50066 mode changed, 0100664 to 0120777
 > 
 > The error is basically telling you that ReiserFS filehandles are being
 > reused by the server. Doesn't Reiser provide a generation count to
 > guard against this sort of thing?

Yes, inode->i_generation is stored in the file handle:
fs/reiserfs/inode.c:reiserfs_dentry_to_fh().

Hans-Peter, what version of NFS are you using and have you remounted
clients after upgrading to the newer kernel?

 > 
 > My 'fix' just solves the immediate problem of the wrong file mode. It
 > does not solve the problems of data corruption that can occur when the
 > client is incapable of distinguishing the 'old' and 'new' files that
 > share the same filehandle.

This requires i_generation overflow (modulo bug in reiserfs).

 > 
 > Cheers,
 >   Trond

Nikita.