From: Trent Piepho <tpiepho@impinj.com>
To: "shawn.lin@rock-chips.com" <shawn.lin@rock-chips.com>,
"niklas.cassel@axis.com" <niklas.cassel@axis.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"kishon@ti.com" <kishon@ti.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"thesven73@gmail.com" <thesven73@gmail.com>,
"gustavo.pimentel@synopsys.com" <gustavo.pimentel@synopsys.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"hongxing.zhu@nxp.com" <hongxing.zhu@nxp.com>
Subject: Re: [RFC BUG] pci: Freescale i.MX6 PCIe controller: revert mainline regression
Date: Tue, 18 Dec 2018 23:06:34 +0000 [thread overview]
Message-ID: <1545174393.22930.65.camel@impinj.com> (raw)
In-Reply-To: <20181218210444.5950-1-TheSven73@googlemail.com>
On Tue, 2018-12-18 at 16:04 -0500, Sven Van Asbroeck wrote:
> We are using a Broadcom BCM57780 ethernet adapter (Tigon3) connected
> to a i.MX6 PCIe controller. On a Freescale i.MX6 SoC.
>
> This combo worked ok on mainline v4.17.
> On mainline v4.18-rc1, a regression was introduced that caused a crash.
> This regression is still present in current mainline as of v4.20-rc7
>
> Bisected the regression to the following merge head:
> commit 0ecda3a08746 ("Merge branch 'pci/kconfig'")
> When this merge head is removed, the regression disappears. This commit
> reverts the changes introduced by the offending merge head.
It's actually commit f3fdfc4ac3a2 ("PCI: Remove host driver Kconfig
selection of CONFIG_PCIEPORTBUS") that made this problem apparent.
But the real bug is not in that commit, but a problem with imx6/7 not
configuring a setting in the RC correctly without pcieportbus, which
should not be necessary.
See "[v4] PCI: imx: make msi work without CONFIG_PCIEPORTBUS=y" by
Richard Zhu for a real fix.
There another bug that makes this driver sometimes lose an MSI, but
that regression was in v4.14 and would not be fixed by your patch, so
this tigon3 problem is almost certainly caused by the previously
mentioned issue with pcieportbus.
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 6671946dbf66..6e4241ac0a1e 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -113,6 +113,7 @@ config PCI_XGENE
> bool "X-Gene PCIe controller"
> depends on ARM64 || COMPILE_TEST
> depends on OF || (ACPI && PCI_QUIRKS)
> + select PCIEPORTBUS
> help
> Say Y here if you want internal PCI support on APM X-Gene SoC.
>
next prev parent reply other threads:[~2018-12-18 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 21:04 [RFC BUG] pci: Freescale i.MX6 PCIe controller: revert mainline regression Sven Van Asbroeck
2018-12-18 23:06 ` Trent Piepho [this message]
2018-12-19 14:36 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545174393.22930.65.camel@impinj.com \
--to=tpiepho@impinj.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=hongxing.zhu@nxp.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=niklas.cassel@axis.com \
--cc=shawn.lin@rock-chips.com \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox