Re: [PATCH v2 3/7] drm: rockchip: vop: add rk3066 vop definitions

Rob Herring
2019-01-11T14:54:29Z

On Sun, Dec 30, 2018 at 06:22:00PM +0100, Heiko Stuebner wrote:
> Hi Johan,
>
> Am Samstag, 29. Dezember 2018, 14:33:14 CET schrieb Johan Jonker:
> > From: Mark Yao <mark.yao@rock-chips.com>
> >
> > This patch adds the rk3066 VOP definitions.
> >
> > The VOP or LCD Controller serves as interface between
> > framebuffer memory and a display device (LCD panel or TV set).
> >
> > This SOC has two symmetrical LCDC's for a dual panel application.
> >
> > A LCDC has 5 display layers.
> > Only 3 are used here.
> >
> > - Video layer 0 (Win0)
> > - Video layer 1 (Win1)
> > - OSD layer (Win2)
>
> Patch itself looks good, we'll need to wait a bit to give Rob a chance
> to look at the (simple) dt-binding change and I'll drop the paragraph
> about the display layers when applying.

Don't wait on me for simple oneline compatible additions.

Acked-by: Rob Herring <robh@kernel.org>

Rob