From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752263AbdBTSPp (ORCPT ); Mon, 20 Feb 2017 13:15:45 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:37490 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbdBTSPk (ORCPT ); Mon, 20 Feb 2017 13:15:40 -0500 X-AuditID: b6c32a38-f79f06d000001a72-c6-58ab3249b127 From: Bartlomiej Zolnierkiewicz To: Geert Uytterhoeven Cc: Tejun Heo , Michael Schmitz , "linux-ide@vger.kernel.org" , linux-m68k , "linux-kernel@vger.kernel.org" , Jens Axboe , Christoph Hellwig Subject: Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support Date: Mon, 20 Feb 2017 19:15:34 +0100 Message-id: <1548730.TDiBKU8UQt@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMKsWRmVeSWpSXmKPExsWy7bCmga6n0eoIg5srhC3+7znGZvHs1l4m i5WrjzJZHNvxiMni8q45bBbLn6xltpjbOp3d4tfyo4wOHB4Tm9+xe+ycdZfdY9OqTjaPQ4c7 GD1Otn5j8dh9s4HN4/MmuQD2KC6blNSczLLUIn27BK6MU2deMBXsEKpYdv0SYwNjP38XIyeH hICJxLp5G5ggbDGJC/fWs3UxcnEICexglLgz5RE7hNPOJHFy8itmmI5djaegEssZJb5d+MIM 4XxllDi4bRrYLDYBK4mJ7asYuxg5OEQEdCXm/GQCqWEWWMck0d3whhWkRljAQaLrTi8jiM0i oCpx/MUSdhCbV0BT4uXXnWDbRAW8JLbsawebySkQLHH3aBszRI2gxI/J91hAbGYBeYl9+6ey Qtg6EmePrWMEWSYhcIhd4tGSlUwgR0gIyEpsOgD1gYvEvqvbWCFsYYlXx7ewQ9jSEqv+3YKG xXRGie2/JSDmbGaUWLV7AlSRtcTh4xehlvFJvPvawwoxn1eio00IosRD4mT3KahyR4nFt9dC Q+sRo8SKoyfYJjDKz0LywywkP8xC8sMCRuZVjGKpBcW56anFhgUmesWJucWleel6yfm5mxjB SUfLYgfjnnM+hxgFOBiVeHgTvq2KEGJNLCuuzD3EKMHBrCTCmyC3OkKINyWxsiq1KD++qDQn tfgQozQHi5I4L6vBxAghgfTEktTs1NSC1CKYLBMHp1QD4/IU5cnXaju1Gqa+jY1g7286Nbdw 9c0fC6Smxj//fuZVrL2nmfnE6ZLLreaw14XOl3Z3++KcO9Hc1sPoRoSh0fM3u8z8H0f5P7t/ KXbJtnIZ34ZAB++9iWfDm49J/Bf4/WTWmpULXewkVj19llR7/2egb+HPxzOf3Vgy93r1T5Yf pmy687YET1diKc5INNRiLipOBAAMWwXQNgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsVy+t9jAV1Po9URBr+/slj833OMzeLZrb1M FitXH2WyOLbjEZPF5V1z2CyWP1nLbDG3dTq7xa/lRxkdODwmNr9j99g56y67x6ZVnWwehw53 MHqcbP3G4rH7ZgObx+dNcgHsUW42GamJKalFCql5yfkpmXnptkqhIW66FkoKeYm5qbZKEbq+ IUFKCmWJOaVAnpEBGnBwDnAPVtK3S3DLOHXmBVPBDqGKZdcvMTYw9vN3MXJySAiYSOxqPMUO YYtJXLi3nq2LkYtDSGApo8SP3nfMEM5XRolJ53eygFSxCVhJTGxfxdjFyMEhIqArMecnE0iY WWAdk8Tel0kgtrCAg0TXnV5GEJtFQFXi+IslYAt4BTQlXn7dyQxiiwp4SWzZ1w7WyykQLLFp 5UWoXU8YJQ5MesYC0SAo8WPyPRaIBfIS+/ZPZYWwtSTW7zzONIFRYBaSsllIymYhKVvAyLyK USK1ILmgOCk91zAvtVyvODG3uDQvXS85P3cTIzgGn0ntYDy4y/0QowAHoxIP744fqyKEWBPL iitzDzFKcDArifAmyK2OEOJNSaysSi3Kjy8qzUktPsRoCvThRGYp0eR8YHrIK4k3NDE3MTc2 sDC3tDQxUhLnbZz9LFxIID2xJDU7NbUgtQimj4mDU6qBcb2q5vTd122+C+xYv1RBomLtJRPP TBWz4tf8hS0smZPsKq9nfGxJ2PK4N0xJ0dy+9lTKzS1Pjsw6uTKCpSb9024tDy27QzHOHwNX H30WMOH2Nz2GL9k6wf9b/osf2PB4+9d9agc465ltj66b3f1p/pKb/xj72hcXTGV5yrGh/EjD r+0xoWu79yixFGckGmoxFxUnAgDBCRwV1wIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170220181537epcas1p49e01126e1ac9418ef6497a43826ddc46 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20161230140139epcas5p160eda5a6a77be084e21f12002c85cc2a X-RootMTR: 20161230140139epcas5p160eda5a6a77be084e21f12002c85cc2a References: <1483106478-1382-1-git-send-email-b.zolnierkie@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wednesday, February 15, 2017 09:45:53 AM Geert Uytterhoeven wrote: > On Fri, Dec 30, 2016 at 3:01 PM, Bartlomiej Zolnierkiewicz > wrote: > > This patchset adds m68k/Atari Falcon PATA support to libata. > > The major difference in the new libata's pata_falcon host > > driver when compared to legacy IDE's falconide host driver is > > that we are using polled PIO mode and thus avoiding the need > > for STDMA locking magic altogether. > > > > Tested under ARAnyM emulator. > > > > Best regards, > > -- > > Bartlomiej Zolnierkiewicz > > Samsung R&D Institute Poland > > Samsung Electronics > > > > > > Bartlomiej Zolnierkiewicz (3): > > ata: allow subsystem to be used on m68k arch > > ata: pass queued command to ->sff_data_xfer method > > ata: add Atari Falcon PATA controller driver > > drivers/ata/pata_falcon.c:57:18: error: 'struct request' has no member > named 'cmd_type' > drivers/ata/pata_falcon.c:57:32: error: 'REQ_TYPE_FS' undeclared > (first use in this function) > > http://kisskb.ellerman.id.au/kisskb/buildresult/12936876/ From: Bartlomiej Zolnierkiewicz Subject: [PATCH] pata_falcon: build fix for block layer changes commit aebf526b53ae ("block: fold cmd_type into the REQ_OP_ space") from the block tree removes cmd_type so pata_falcon needs the following trivial update to make it build again. Reported-by: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- Tejun, I guess that you may need to fold this fix into your pull request for 4.11 (block layer pull request has been already sent by Jens so it will be most likely merged first). drivers/ata/pata_falcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ata/pata_falcon.c =================================================================== --- a/drivers/ata/pata_falcon.c 2017-02-20 18:40:04.174989455 +0100 +++ b/drivers/ata/pata_falcon.c 2017-02-20 18:42:59.482993870 +0100 @@ -54,7 +54,7 @@ static unsigned int pata_falcon_data_xfe bool swap = 1; if (dev->class == ATA_DEV_ATA && cmd && cmd->request && - cmd->request->cmd_type == REQ_TYPE_FS) + !blk_rq_is_passthrough(cmd->request)) swap = 0; /* Transfer multiple of 2 bytes */