From: Carolina Jubran <cjubran@nvidia.com>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Kuniyuki Iwashima <kuniyu@google.com>,
Kees Cook <kees@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Cosmin Ratiu <cratiu@nvidia.com>,
Dragos Tatulea <dtatulea@nvidia.com>
Subject: Re: [PATCH net] net: dev_ioctl: take ops lock in hwtstamp lower paths
Date: Fri, 5 Sep 2025 08:35:37 +0300 [thread overview]
Message-ID: <154e30fa-9465-4e4e-a1f4-410ef73c04cf@nvidia.com> (raw)
In-Reply-To: <20250904235155.7b2b3379@kmaincent-XPS-13-7390>
On 05/09/2025 0:52, Kory Maincent wrote:
> On Thu, 4 Sep 2025 21:28:06 +0300
> Carolina Jubran <cjubran@nvidia.com> wrote:
>
>> ndo hwtstamp callbacks are expected to run under the per-device ops
>> lock. Make the lower get/set paths consistent with the rest of ndo
>> invocations.
>>
>> Kernel log:
>> WARNING: CPU: 13 PID: 51364 at ./include/net/netdev_lock.h:70
>> __netdev_update_features+0x4bd/0xe60 ...
>> RIP: 0010:__netdev_update_features+0x4bd/0xe60
>> ...
>> Call Trace:
>> <TASK>
>> netdev_update_features+0x1f/0x60
>> mlx5_hwtstamp_set+0x181/0x290 [mlx5_core]
>> mlx5e_hwtstamp_set+0x19/0x30 [mlx5_core]
> Where does these two functions come from? They are not mainline.
> Else LGTM.
You are right, I hit this when I was working on another patch to
convert the legacy ndo. I thought it would be nice to have the
kernel log in the commit message.
Thanks,
Carolina
next prev parent reply other threads:[~2025-09-05 5:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 18:28 [PATCH net] net: dev_ioctl: take ops lock in hwtstamp lower paths Carolina Jubran
2025-09-04 21:52 ` Kory Maincent
2025-09-05 5:35 ` Carolina Jubran [this message]
2025-09-05 13:07 ` Simon Horman
2025-09-05 23:27 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154e30fa-9465-4e4e-a1f4-410ef73c04cf@nvidia.com \
--to=cjubran@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kees@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox