From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5540C43381 for ; Thu, 14 Feb 2019 17:32:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8533221928 for ; Thu, 14 Feb 2019 17:32:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436870AbfBNRct (ORCPT ); Thu, 14 Feb 2019 12:32:49 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:47551 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728194AbfBNRcs (ORCPT ); Thu, 14 Feb 2019 12:32:48 -0500 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1guKsL-00085S-10; Thu, 14 Feb 2019 18:32:41 +0100 Message-ID: <1550165560.2546.50.camel@pengutronix.de> Subject: Re: [RFC 5/5] arm64: dts: imx8mq: Add the opp table and the cpu-supply nodes From: Lucas Stach To: Abel Vesa Cc: Rob Herring , Stephen Boyd , Mark Rutland , Mike Turquette , Shawn Guo , Sascha Hauer , Angus Ainslie , Anson Huang , dl-linux-imx , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "devicetree@vger.kernel.org" Date: Thu, 14 Feb 2019 18:32:40 +0100 In-Reply-To: <1550165185.2546.48.camel@pengutronix.de> References: <1550084693-9797-1-git-send-email-abel.vesa@nxp.com> <1550084693-9797-6-git-send-email-abel.vesa@nxp.com> <1550159428.2546.40.camel@pengutronix.de> <20190214171806.kufhw7ouguxt5jhq@fsr-ub1664-175> <1550165185.2546.48.camel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 14.02.2019, 18:26 +0100 schrieb Lucas Stach: > Am Donnerstag, den 14.02.2019, 17:18 +0000 schrieb Abel Vesa: > > On 19-02-14 16:50:28, Lucas Stach wrote: > > > Hi Abel > > > > > > Am Mittwoch, den 13.02.2019, 19:05 +0000 schrieb Abel Vesa: > > > > Add the opp table containing only non over drive opps. > > > > Also add the cpu-supply nodes for the A53 cores in the EVK > > > > board. > > > > > > > > Signed-off-by: Abel Vesa > > > > --- > > > >  arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 17 > > > > +++++++++++++++++ > > > >  arch/arm64/boot/dts/freescale/imx8mq.dtsi    | 23 > > > > +++++++++++++++++++++++ > > > >  2 files changed, 40 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > > > > b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > > > > index 54737bf..114359e 100644 > > > > --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > > > > @@ -31,6 +31,23 @@ > > > >   gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; > > > >   enable-active-high; > > > >   }; > > > > + > > > > +}; > > > > + > > > > +&A53_0 { > > > > + cpu-supply = <&sw1a_reg>; > > > > +}; > > > > + > > > > +&A53_1 { > > > > + cpu-supply = <&sw1a_reg>; > > > > +}; > > > > + > > > > +&A53_2 { > > > > + cpu-supply = <&sw1a_reg>; > > > > +}; > > > > + > > > > +&A53_3 { > > > > + cpu-supply = <&sw1a_reg>; > > > >  }; > > > > > > This should be a separate patch. > > > > > > > OK, will send as separate patches in the next version. > > > > > And AFAICS this is wrong, sw1a on the MX8M-EVK is the GPU supply, > > > the > > > CPU is supplied by a dedicated switcher that is controlled via a > > > GPIO. > > > > > > > Hmm, I think you're right. At least this is what the following > > document says. > > > > https://www.mouser.com/ds/2/302/IMX8MDQLQEVKHUG-1280333.pdf > > > > So I guess this means there will not be any cpu-supply properties.  > > There is a variable voltage CPU supply, but you need to model it as a > gpio-regulator in the DT, it's not part of the PMIC provided rails. In the schematics it's the line called PWM_LED (actually it's just GPIO1_IO13) that controls the voltage. This changes the feedback of the DCDC switcher, so it can toggle between 0.9V and 1.0V. Regards, Lucas