From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A402C43381 for ; Fri, 1 Mar 2019 15:57:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25A642084F for ; Fri, 1 Mar 2019 15:57:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388928AbfCAP5P (ORCPT ); Fri, 1 Mar 2019 10:57:15 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:46610 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728416AbfCAP5P (ORCPT ); Fri, 1 Mar 2019 10:57:15 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x21Fv97k027572 for ; Fri, 1 Mar 2019 10:57:13 -0500 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0b-001b2d01.pphosted.com with ESMTP id 2qy6vqu2jg-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 01 Mar 2019 10:57:11 -0500 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 1 Mar 2019 15:56:44 -0000 Received: from b01cxnp23033.gho.pok.ibm.com (9.57.198.28) by e17.ny.us.ibm.com (146.89.104.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 1 Mar 2019 15:56:40 -0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x21FudwO21102758 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 Mar 2019 15:56:39 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 35D35124058; Fri, 1 Mar 2019 15:56:39 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2515D124054; Fri, 1 Mar 2019 15:56:38 +0000 (GMT) Received: from jarvis.ext.hansenpartnership.com (unknown [9.80.228.140]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 1 Mar 2019 15:56:37 +0000 (GMT) Subject: Re: [PATCH v2] scsi: smartpqi_init: Reporting 'logical unit failure' From: James Bottomley To: Erwan Velu , Erwan Velu , "elliott@hpe.com" Cc: Don Brace , "Martin K. Petersen" , "open list:MICROSEMI SMART ARRAY SMARTPQI DRIVER (smartpqi)" , "open list:MICROSEMI SMART ARRAY SMARTPQI DRIVER (smartpqi)" , open list Date: Fri, 01 Mar 2019 07:56:37 -0800 In-Reply-To: References: <20190227163133.26283-1-e.velu@criteo.com> <20190301145832.12735-1-e.velu@criteo.com> <1551453987.3334.2.camel@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19030115-0040-0000-0000-000004CA0FD1 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010686; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000281; SDB=6.01168118; UDB=6.00606765; IPR=6.00948734; MB=3.00025796; MTD=3.00000008; XFM=3.00000015; UTC=2019-03-01 15:56:43 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19030115-0041-0000-0000-000008D518DF Message-Id: <1551455797.3334.6.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-01_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=790 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903010112 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-03-01 at 15:43 +0000, Erwan Velu wrote: > Le 01/03/2019 à 16:26, James Bottomley a écrit : > > [...] > > Shouldn't this be a variant of sdev/scmd_printk? Otherwise it > > tells > > you what disk in the array terms is the problem but not what device > > in > > your actual system is affected. > > Hey James, > > My initial take on that was that pqi_take_device_offline(), which is > called just after, will print the "re-scanning " message with the > same > format. > > As they will be both printed in the same error context and one after > the > other, I though that would make sense to represent the same > information > to ease the reading like cause -> consequence. > > As the message is about the LUN itself, which is reported faulty, I > though it would worth reporting the info that way. > > Shall I consider printing also the disk name in addition ? I was thinking just if (printk_ratelimit()) scmd_printk(KERN_ERR, scmd, "received 'logical unit failure' from controller for scsi %d:%d:%d:%d\n", ... That will give all the necessary information James