From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAE7AC43381 for ; Mon, 4 Mar 2019 18:22:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 976F420663 for ; Mon, 4 Mar 2019 18:22:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="SS6r+bCV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727790AbfCDSWb (ORCPT ); Mon, 4 Mar 2019 13:22:31 -0500 Received: from outils.crapouillou.net ([89.234.176.41]:43036 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbfCDSWb (ORCPT ); Mon, 4 Mar 2019 13:22:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1551723749; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dHwuU9Y+V+vVpKPqoBrFRK246RbRVM7QYbYfLWrqTeI=; b=SS6r+bCVTYvktntxuSPxrlBq64mAYcPiuWIyH0lr4cP3s97iayrC1AbLLyT8CV+yhyckPq RzPRg92ELhMZ1WJmeblbOWmKT57OGZaCk9pZA0rLxzg7khTavX/iXjK7qL1yWTUAMkUPWu LDyEdTPRZKHFdL20ggJq7PLD6tZelso= Date: Mon, 04 Mar 2019 19:22:22 +0100 From: Paul Cercueil Subject: Re: [PATCH v4 1/9] dt-bindings: mtd: ingenic: Add compatible strings for JZ4740 and JZ4725B To: Miquel Raynal Cc: David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger , Rob Herring , Mark Rutland , Harvey Hunt , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <1551723742.4932.2@crapouillou.net> In-Reply-To: <20190304104554.09be4cd4@xps13> References: <20190209192305.4434-1-paul@crapouillou.net> <20190304104554.09be4cd4@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miquel, On Mon, Mar 4, 2019 at 10:45 AM, Miquel Raynal=20 wrote: > Hi Paul, >=20 > Paul Cercueil >=20 > wrote on Sat, 9 Feb 2019 16:22:57 > -0300: >=20 >> Add compatible strings to probe the jz4780-nand and jz4780-bch=20 >> drivers >> from devicetree on the JZ4725B and JZ4740 SoCs from Ingenic. >>=20 >> Signed-off-by: Paul Cercueil > > >> --- >>=20 >> Changes: >>=20 >> v2: - Change 'ingenic,jz4725b-nand' compatible string to >> 'ingenic,jz4740-nand' to reflect driver change >> - Add 'ingenic,jz4740-bch' compatible string >> - Document 'ingenic,oob-layout' property >>=20 >> v3: - Removed 'ingenic,oob-layout' property >> - Update compatible strings to what the driver supports >>=20 >> v4: No change >>=20 >> Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt | 10=20 >> ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >>=20 >> diff --git=20 >> a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt=20 >> b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt >> index 29ea5853ca91..a5b940f18bf6 100644 >> --- a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt >> +++ b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt >> @@ -6,7 +6,10 @@ memory-controllers/ingenic,jz4780-nemc.txt), and=20 >> thus NAND device nodes must >> be children of the NEMC node. >>=20 >> Required NAND controller device properties: >> -- compatible: Should be set to "ingenic,jz4780-nand". >> +- compatible: Should be one of: >> + * ingenic,jz4740-nand >> + * ingenic,jz4725b-nand >> + * ingenic,jz4780-nand >=20 > Wouldn't "-nand-controller" suffix be better? Of course in the driver > you should still check for jz4780-nand. So I would be compatible with: * ingenic,jz4740-nand-controller * ingenic,jz4725b-nand-controller * ingenic,jz4780-nand ? >> - reg: For each bank with a NAND chip attached, should specify a=20 >> bank number, >> an offset of 0 and a size of 0x1000000 (i.e. the whole NEMC=20 >> bank). >>=20 >> @@ -72,7 +75,10 @@ NAND devices. The following is a description of=20 >> the device properties for a >> BCH controller. >>=20 >> Required BCH properties: >> -- compatible: Should be set to "ingenic,jz4780-bch". >> +- compatible: Should be one of: >> + * ingenic,jz4740-ecc >> + * ingenic,jz4725b-bch >> + * ingenic,jz4780-bch >> - reg: Should specify the BCH controller registers location and=20 >> length. >> - clocks: Clock for the BCH controller. >>=20 >=20 > Thanks, > Miqu=E8l =