From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B309C4338F for ; Thu, 29 Jul 2021 02:00:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 685686056C for ; Thu, 29 Jul 2021 02:00:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233300AbhG2CBA (ORCPT ); Wed, 28 Jul 2021 22:01:00 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:7888 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233162AbhG2CA5 (ORCPT ); Wed, 28 Jul 2021 22:00:57 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GZtv72w4zz81YK; Thu, 29 Jul 2021 09:57:07 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 29 Jul 2021 10:00:53 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 29 Jul 2021 10:00:51 +0800 Subject: Re: [PATCH v2 5/7] kallsyms: Rename is_kernel() and is_kernel_text() To: Steven Rostedt CC: , , , , , , , , , , , Daniel Borkmann , Sami Tolvanen , Nathan Chancellor , References: <20210728081320.20394-1-wangkefeng.wang@huawei.com> <20210728081320.20394-6-wangkefeng.wang@huawei.com> <20210728112836.289865f5@oasis.local.home> From: Kefeng Wang Message-ID: <1551f9cc-eaf8-efef-0590-e2549eebe4ae@huawei.com> Date: Thu, 29 Jul 2021 10:00:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20210728112836.289865f5@oasis.local.home> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/7/28 23:28, Steven Rostedt wrote: > On Wed, 28 Jul 2021 16:13:18 +0800 > Kefeng Wang wrote: > >> The is_kernel[_text]() function check the address whether or not >> in kernel[_text] ranges, also they will check the address whether >> or not in gate area, so use better name. > Do you know what a gate area is? > > Because I believe gate area is kernel text, so the rename just makes it > redundant and more confusing. Yes, the gate area(eg, vectors part on ARM32, similar on x86/ia64) is kernel text. I want to keep the 'basic' section boundaries check, which only check the start/end of sections, all in section.h,  could we use 'generic' or 'basic' or 'core' in the naming? * is_kernel_generic_data() --- come from core_kernel_data() in kernel.h * is_kernel_generic_text() The old helper could remain unchanged, any suggestion, thanks. > > -- Steve > . >