From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BCDBC43381 for ; Fri, 8 Mar 2019 01:41:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E2E3B20675 for ; Fri, 8 Mar 2019 01:41:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726298AbfCHBlb (ORCPT ); Thu, 7 Mar 2019 20:41:31 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:2398 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726241AbfCHBlb (ORCPT ); Thu, 7 Mar 2019 20:41:31 -0500 X-UUID: 5e9e5bb923f043a6bbc4b8bcdf83a558-20190308 X-UUID: 5e9e5bb923f043a6bbc4b8bcdf83a558-20190308 Received: from mtkmrs01.mediatek.inc [(172.21.131.159)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1572907429; Fri, 08 Mar 2019 09:41:24 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 8 Mar 2019 09:41:22 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 8 Mar 2019 09:41:23 +0800 Message-ID: <1552009283.2863.12.camel@mtksdaap41> Subject: Re: [PATCH v2 03/10] dt-binding: gce: add binding for gce subsys property From: CK Hu To: Bibby Hsieh CC: Jassi Brar , Matthias Brugger , Rob Herring , Daniel Kurtz , Sascha Hauer , , , , , , Sascha Hauer , "Philipp Zabel" , Nicolas Boichat , "YT Shen" , Daoyuan Huang , Jiaguang Zhang , Dennis-YC Hsieh , Houlong Wei , , , Frederic Chen Date: Fri, 8 Mar 2019 09:41:23 +0800 In-Reply-To: <1551865835-50974-4-git-send-email-bibby.hsieh@mediatek.com> References: <1551865835-50974-1-git-send-email-bibby.hsieh@mediatek.com> <1551865835-50974-4-git-send-email-bibby.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Bibby: On Wed, 2019-03-06 at 17:50 +0800, Bibby Hsieh wrote: > cmdq driver provide a function that get the relationship > of sub system number from device node for client. > add specification for #subsys-cells, mediatek,gce-subsys. > > Signed-off-by: Bibby Hsieh > --- > Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > index 812698f..07b2adf 100644 > --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > @@ -26,6 +26,13 @@ Required properties: > phandle: Label name of a gce node. > event_number: the event number defined in 'dt-bindings/gce/mt8173-gce.h' > or 'dt-binding/gce/mt8183-gce.h'. > +#subsys-cells: Should be 2. > + <&phandle register_base_address subsys_number> > + phandle: Label name of a gce node. > + register_base_address: the register base address that client > + want to write or read. > + subsys_number: specify the sub-system id which is corresponding > + to the register address. I would like this description similar to 'reg' property. For example: If a client want GCE to access register from 0x14002000 ~ 0x14002fff, in the view of GCE, it would access register from SUBSYS_1400XXXX with an offset 0x2000 to SUBSYS_1400XXXX with an offset 0x2fff So the description could be: mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x2000 0x1000> the second parameter is subsys, the third parameter is start offset, and the fourth parameter is the size. I change the property name to 'mediatek,gce-client-reg' because this whole property describe the range GCE access rather than the subsys. Regards, CK > > Required properties for a client device: > - mboxes: Client use mailbox to communicate with GCE, it should have this > @@ -50,6 +57,7 @@ Example: > thread-num = CMDQ_THR_MAX_COUNT; > #mbox-cells = <3>; > #event-cells = <1>; > + #subsys-cells = <2>; > }; > > Example for a client device: > @@ -58,7 +66,8 @@ Example for a client device: > compatible = "mediatek,mt8173-mmsys"; > mboxes = <&gce 0 CMDQ_THR_PRIO_LOWEST 1>, > <&gce 1 CMDQ_THR_PRIO_LOWEST 1>; > - mediatek,gce-subsys = ; > + mediatek,gce-subsys = <&gce 0x14000000 SUBSYS_1400XXXX>, > + <&gce 0x14010000 SUBSYS_1401XXXX>; > mediatek,gce-event-names = "rdma0_sof", > "rsz0_sof"; > mediatek,gce-events = <&gce CMDQ_EVENT_MDP_RDMA0_SOF>,