From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A701C43381 for ; Sat, 16 Mar 2019 21:56:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DAC3218A1 for ; Sat, 16 Mar 2019 21:56:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="nbBw8ixz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726923AbfCPV4n (ORCPT ); Sat, 16 Mar 2019 17:56:43 -0400 Received: from outils.crapouillou.net ([89.234.176.41]:34214 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726571AbfCPV4m (ORCPT ); Sat, 16 Mar 2019 17:56:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1552773399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=spMUG794ufqR0LGT4uC7wAyLFhA8ETuF+HiqDZ21FBw=; b=nbBw8ixzMBEUXUgpNP5Y9H5Dh6YIxSQYC1Qz5LywvSwrI52RpqhW6FjSB33RDWy60UXWdG BSQMlCAqROTarUSy+CTDwKmThIhBoNwfOIZQd2vBz15X+llYZtVah0LWTgJQ7c/fa7QOj/ aouT/0fUBQqrWTcFiQNCU3pcm76J0sg= Date: Sat, 16 Mar 2019 22:56:35 +0100 From: Paul Cercueil Subject: Re: [PATCH v2 1/3] dt-bindings: Add doc for the ingenic-drm driver To: Sam Ravnborg Cc: Rob Herring , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Maarten Lankhorst , Maxime Ripard , Sean Paul , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Message-Id: <1552773395.1562.1@crapouillou.net> In-Reply-To: <20190316205945.GA11309@ravnborg.org> References: <20190315170701.29670-1-paul@crapouillou.net> <20190316205945.GA11309@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sam, Le sam. 16 mars 2019 =E0 21:59, Sam Ravnborg a =E9crit=20 : > Hi Paul. >=20 > On Fri, Mar 15, 2019 at 06:06:59PM +0100, Paul Cercueil wrote: >> Add documentation for the devicetree bindings of the DRM driver for=20 >> the >> JZ47xx family of SoCs from Ingenic. >>=20 >> Signed-off-by: Paul Cercueil >> Tested-by: Artur Rojek >> --- >>=20 >> Notes: >> v2: Remove ingenic,panel property. >>=20 >> .../devicetree/bindings/display/ingenic,drm.txt | 29=20 >> ++++++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> create mode 100644=20 >> Documentation/devicetree/bindings/display/ingenic,drm.txt >>=20 >> diff --git=20 >> a/Documentation/devicetree/bindings/display/ingenic,drm.txt=20 >> b/Documentation/devicetree/bindings/display/ingenic,drm.txt >> new file mode 100644 >> index 000000000000..f57a4ae0f7ac >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/ingenic,drm.txt >> @@ -0,0 +1,29 @@ >> +Ingenic JZ47xx DRM driver >> + >> +Required properties: >> +- compatible: one of: >> + * ingenic,jz4740-drm >> + * ingenic,jz4725b-drm >> +- reg: LCD registers location and length >> +- clocks: LCD pixclock and device clock specifiers. >> + The device clock is only required on the JZ4740. >> +- clock-names: "lcd_pclk" and "lcd" >> +- interrupts: Specifies the interrupt line the LCD controller is=20 >> connected to. >> + >> +Optional properties: >> +- ingenic,lcd-mode: LCD mode to use with the display panel. >> + See for all the >> + possible values. >=20 > The value of the ingenic,lcd-mode depends on the panel used. > So this looks like a panel property and not a display property. >=20 > The panel should be specified using an OF graph binding > in a port sub-node. > The remote-endpoint will specifify the panel properties > and if the panel requires something special from the display driver, > the panle should specify this. > So one can change panel without touching the display node > in the DT. Then the 'ingenic,lcd-mode' property would be in the panel node, even though it's not used by the panel driver but by the DRM driver? That sounds strange to me. >> + >> +Example: >> + >> +lcd: lcd-controller@13050000 { >> + compatible =3D "ingenic,jz4725b-drm"; >> + reg =3D <0x13050000 0x1000>; >> + >> + interrupt-parent =3D <&intc>; >> + interrupts =3D <31>; >> + >> + clocks =3D <&cgu JZ4725B_CLK_LCD>; >> + clock-names =3D "lcd"; >> +}; >=20 > As hinted above the panel is not specified above and to follow the > modern way to do so would be to use a OF graph binding. It's done this way in the DRM driver now, but I didn't update the example. I will update it in the next version. -Paul =