From: Tom Zanussi <tzanussi@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Mario Limonciello" <mario.limonciello@dell.com>,
linux-kernel@vger.kernel.org
Subject: Re: dell_smbios KASAN bug
Date: Wed, 20 Mar 2019 15:28:56 -0500 [thread overview]
Message-ID: <1553113736.2015.2.camel@gmail.com> (raw)
In-Reply-To: <20190320154534.46ebab51@gandalf.local.home>
On Wed, 2019-03-20 at 15:45 -0400, Steven Rostedt wrote:
> On Wed, 20 Mar 2019 14:30:21 -0500
> Tom Zanussi <tzanussi@gmail.com> wrote:
>
> > > diff --git a/drivers/platform/x86/dell-smbios-base.c
> > > b/drivers/platform/x86/dell-smbios-base.c
> > > index 9dc282ed5a9e..c3825c674522 100644
> > > --- a/drivers/platform/x86/dell-smbios-base.c
> > > +++ b/drivers/platform/x86/dell-smbios-base.c
> > > @@ -619,6 +619,7 @@ static int __init dell_smbios_init(void)
> > >
> > > fail_platform_driver:
> > > kfree(da_tokens);
> > > + da_num_tokens = 0;
> > > return ret;
> > > }
> > >
> >
> >
> > Unfortunately, no.
>
> That's really weird. I would recommend throwing in a bunch of printks
> to see if things are being freed and set, to make sure this code is
> hit
> and something else isn't just corrupting it.
>
Actually the patch does make the KASAN bug go away - I'm so used to
building without modules that I forgot to rebuild the module after
applying the patch, sigh.
Tom
> -- Steve
next prev parent reply other threads:[~2019-03-20 20:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 18:29 dell_smbios KASAN bug Tom Zanussi
2019-03-20 18:41 ` Steven Rostedt
2019-03-20 19:05 ` Tom Zanussi
2019-03-20 19:13 ` Steven Rostedt
2019-03-20 19:30 ` Tom Zanussi
2019-03-20 19:45 ` Steven Rostedt
2019-03-20 20:28 ` Tom Zanussi [this message]
2019-03-20 20:32 ` Steven Rostedt
2019-03-20 20:44 ` Tom Zanussi
2019-03-25 13:22 ` Mario.Limonciello
2019-03-25 14:17 ` Steven Rostedt
2019-03-25 16:20 ` Tom Zanussi
2019-04-03 17:16 ` Steven Rostedt
2019-04-03 19:14 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553113736.2015.2.camel@gmail.com \
--to=tzanussi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=pali.rohar@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox