From: Bart Van Assche <bvanassche@acm.org>
To: Will Deacon <will.deacon@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Waiman Long <longman@redhat.com>,
shenghui <shhuiw@foxmail.com>
Subject: Re: [PATCH] locking/lockdep: Zap lock classes even with lock debugging disabled
Date: Wed, 03 Apr 2019 14:15:29 -0700 [thread overview]
Message-ID: <1554326129.118779.234.camel@acm.org> (raw)
In-Reply-To: <20190403124410.GE16362@fuggles.cambridge.arm.com>
On Wed, 2019-04-03 at 13:44 +0100, Will Deacon wrote:
> > --- a/kernel/locking/lockdep.c
> > +++ b/kernel/locking/lockdep.c
> > @@ -4689,8 +4689,7 @@ static void free_zapped_rcu(struct rcu_head *ch)
> > return;
> >
> > raw_local_irq_save(flags);
> > - if (!graph_lock())
> > - goto out_irq;
> > + arch_spin_lock(&lockdep_lock);
>
> This also throws out the recursion counting. Is that ok?
Apparently not, as the build bot just figured out. I will restore recursion
counting. See also
https://lore.kernel.org/lkml/5ca4ea66.eVtXtf5CmqRjP7xF%25lkp@intel.com/.
Bart.
prev parent reply other threads:[~2019-04-03 21:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 19:59 [PATCH] locking/lockdep: Zap lock classes even with lock debugging disabled Bart Van Assche
2019-04-03 12:44 ` Will Deacon
2019-04-03 15:48 ` Bart Van Assche
2019-04-03 17:33 ` Will Deacon
2019-04-03 21:15 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554326129.118779.234.camel@acm.org \
--to=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shhuiw@foxmail.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox