From: Eugeniy Paltsev <eugeniy.paltsev@synopsys.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jose Abreu <jose.abreu@synopsys.com>
Cc: Joao Pinto <joao.pinto@synopsys.com>,
"nelson.costa@synopsys.com" <nelson.costa@synopsys.com>,
Luis de Oliveira <luis.oliveira@synopsys.com>,
"vitor.soares@synopsys.com" <vitor.soares@synopsys.com>,
"eugeniy.Paltsev@synopsys.com" <eugeniy.paltsev@synopsys.com>,
"gustavo.pimentel@synopsys.com" <gustavo.pimentel@synopsys.com>,
"Alexey Brodkin" <alexey.brodkin@synopsys.com>,
"jose.abreu@synopsys.com" <jose.abreu@synopsys.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"pedrom.sousa@synopsys.com" <pedrom.sousa@synopsys.com>
Subject: Re: [PATCH] reset: axs10x: Implement assert and deassert callbacks
Date: Fri, 12 Apr 2019 13:26:26 +0000 [thread overview]
Message-ID: <1555075583.2668.20.camel@synopsys.com> (raw)
In-Reply-To: <78EB27739596EE489E55E81C33FEC33A0B44FBB5@DE02WEMBXB.internal.synopsys.com>
Hi Jose,
On Mon, 2019-04-08 at 11:23 +0000, Jose Abreu wrote:
> From: Vitor Soares <vitor.soares@synopsys.com>
> Date: Mon, Apr 08, 2019 at 11:31:23
>
> > static const struct reset_control_ops axs10x_reset_ops = {
> > - .reset = axs10x_reset_reset,
>
> Eugeniy, Alexey,
>
> I think the implementation of this callback is wrong: you should
> readl_poll_timeout_atomic() until the reset bit is not cleared.
I don't remember if this register is read/write or write-only. I'll check it.
Thanks for report.
>
> Thanks,
> Jose Miguel Abreu
--
Eugeniy Paltsev
next prev parent reply other threads:[~2019-04-12 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 10:31 [PATCH] reset: axs10x: Implement assert and deassert callbacks Vitor Soares
2019-04-08 11:23 ` Jose Abreu
2019-04-12 13:26 ` Eugeniy Paltsev [this message]
2019-04-08 11:40 ` Eugeniy Paltsev
2019-04-08 13:25 ` Vitor Soares
2019-04-12 13:22 ` Eugeniy Paltsev
2019-04-12 14:42 ` Vitor Soares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1555075583.2668.20.camel@synopsys.com \
--to=eugeniy.paltsev@synopsys.com \
--cc=alexey.brodkin@synopsys.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=joao.pinto@synopsys.com \
--cc=jose.abreu@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luis.oliveira@synopsys.com \
--cc=nelson.costa@synopsys.com \
--cc=p.zabel@pengutronix.de \
--cc=pedrom.sousa@synopsys.com \
--cc=vitor.soares@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox