From: Qian Cai <cai@lca.pw>
To: Borislav Petkov <bp@alien8.de>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com,
x86@kernel.org, linux-kernel@vger.kernel.org,
Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [PATCH] x86/mm/mem_encrypt: fix a crash with kmemleak_scan
Date: Tue, 23 Apr 2019 10:16:46 -0400 [thread overview]
Message-ID: <1556029006.6132.1.camel@lca.pw> (raw)
In-Reply-To: <20190423132518.GA16353@zn.tnic>
On Tue, 2019-04-23 at 15:25 +0200, Borislav Petkov wrote:
> So I guess free_init_pages() should be somehow telling kmemleak, "hey,
> just freed that object, pls adjust your tracking lists" no?
>
> Because, otherwise, if we start sprinkling those kmemleak_free_part()
> calls everywhere, that'll quickly turn into a game of whack-a-mole. And
> we don't need that especially if kmemleak can easily be taught to handle
> such cases.
In reality, this is only the second place that needs this kmemleak_free_part()
call for all those years since kmemleak was born.
next prev parent reply other threads:[~2019-04-23 14:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 4:05 [PATCH] x86/mm/mem_encrypt: fix a crash with kmemleak_scan Qian Cai
2019-04-16 13:44 ` Catalin Marinas
2019-04-16 17:11 ` Borislav Petkov
2019-04-17 0:38 ` Qian Cai
2019-04-18 7:45 ` Borislav Petkov
2019-04-18 9:50 ` Catalin Marinas
2019-04-23 13:25 ` Borislav Petkov
2019-04-23 14:02 ` Catalin Marinas
2019-04-23 15:17 ` Borislav Petkov
2019-04-23 14:16 ` Qian Cai [this message]
2019-04-23 15:18 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556029006.6132.1.camel@lca.pw \
--to=cai@lca.pw \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox