From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A3CC43219 for ; Mon, 29 Apr 2019 09:45:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6ECB32087B for ; Mon, 29 Apr 2019 09:45:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727757AbfD2Jpm (ORCPT ); Mon, 29 Apr 2019 05:45:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:56282 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727239AbfD2Jpm (ORCPT ); Mon, 29 Apr 2019 05:45:42 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 80E2CAD43; Mon, 29 Apr 2019 09:45:40 +0000 (UTC) Message-ID: <1556531138.5647.1.camel@suse.de> Subject: Re: [Bug 203297] Synaptics touchpad TM-3127 functionality broken by PCI runtime power management patch on 4.20.2 From: Jean Delvare To: Benjamin Tissoires , Jarkko Nikula Cc: Bjorn Helgaas , Keijo Vaara , "Rafael J. Wysocki" , Dmitry Torokhov , linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, lkml , linux-input@vger.kernel.org, Wolfram Sang Date: Mon, 29 Apr 2019 11:45:38 +0200 In-Reply-To: References: <20190422130814.GJ173520@google.com> <3a1139ef-10ed-6923-73c5-30fbf0c065c3@linux.intel.com> Organization: Suse Linux Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-04-29 at 10:53 +0200, Benjamin Tissoires wrote: > On Mon, Apr 29, 2019 at 10:38 AM Jarkko Nikula > wrote: > > I got another thought about this. I noticed these input drivers need > > SMBus Host Notify, maybe that explain the PM dependency? If that's the > > only dependency then we could prevent the controller suspend if there is > > a client needing host notify mechanism. IMHO that's less hack than the > > patch to rmi_smbus.c. > > So currently, AFAIK, only Synaptics (rmi4) and Elantech are using > SMBus Host Notify. > So this patch would prevent the same bugs for those 2 vendors, which is good. > > It took me some time to understand why this would be less than a hack. > And indeed, given that Host Notify relies on the I2C connection to be > ready for the IRQ, we can not put the controller in suspend like we do > for others where the IRQ controller is still ready. > > So yes, that could work from me. Not sure what Wolfram and Jean would > say though. I would say OK with me, this looks like the cleanest solution to me, so if testing is positive, let's go with it. -- Jean Delvare SUSE L3 Support