Re: [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

Randy Dunlap
2018-01-19T22:12:48Z

On 01/16/2018 01:44 PM, Jacopo Mondi wrote:
> Hello,
> new version of CEU after Hans' review.
>
> Added his Acked-by to most patches and closed review comments.
> Running v4l2-compliance, I noticed a new failure introduced by the way I now
> calculate the plane sizes in set/try_fmt.

I would expect that you have already seen this, but I get a build error
in renesas-ceu.c. Here is a small patch for it.

---
From: Randy Dunlap <rdunlap@infradead.org>

Fix build error (on x86 with COMPILE_TEST):

../drivers/media/platform/renesas-ceu.c: In function 'ceu_parse_dt':
../drivers/media/platform/renesas-ceu.c:1497:27: error: request for member 'fwnode' in something not a structure or union
ceu_sd->asd.match.fwnode.fwnode =

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
drivers/media/platform/renesas-ceu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20180119.orig/drivers/media/platform/renesas-ceu.c
+++ linux-next-20180119/drivers/media/platform/renesas-ceu.c
@@ -1494,7 +1494,7 @@ static int ceu_parse_dt(struct ceu_devic

ceu_sd->mbus_flags = fw_ep.bus.parallel.flags;
ceu_sd->asd.match_type = V4L2_ASYNC_MATCH_FWNODE;
- ceu_sd->asd.match.fwnode.fwnode =
+ ceu_sd->asd.match.fwnode =
fwnode_graph_get_remote_port_parent(
of_fwnode_handle(ep));