From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3639CC004C9 for ; Sun, 5 May 2019 07:44:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 072442082F for ; Sun, 5 May 2019 07:44:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727519AbfEEHoY (ORCPT ); Sun, 5 May 2019 03:44:24 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:16973 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726524AbfEEHoY (ORCPT ); Sun, 5 May 2019 03:44:24 -0400 X-UUID: bca66897c5a5492c9a238fe0951bb677-20190505 X-UUID: bca66897c5a5492c9a238fe0951bb677-20190505 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 720570531; Sun, 05 May 2019 15:43:55 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS33N1.mediatek.inc (172.27.4.75) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 5 May 2019 15:43:54 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sun, 5 May 2019 15:43:53 +0800 Message-ID: <1557042233.18628.33.camel@mhfsdcap03> Subject: Re: [PATCH 1/4] mmc: mtk-sd: don't hard-code interrupt trigger type From: Chaotian Jing To: NeilBrown CC: Ulf Hansson , , , Date: Sun, 5 May 2019 15:43:53 +0800 In-Reply-To: <155696549653.8632.3279283591868841381.stgit@noble.brown> References: <155696540998.8632.5242582397805128125.stgit@noble.brown> <155696549653.8632.3279283591868841381.stgit@noble.brown> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2019-05-04 at 20:24 +1000, NeilBrown wrote: > When using devicetree for configuration, interrupt trigger type > should be described in the dts file, not hard-coded in the C code. > > The mtk-sd silicon in the mt7621 soc uses an active-high interrupt > and so cannot be used with the current code. > > So replace IRQF_TRIGGER_LOW with IRQF_TRIGGER_NONE. > > Also IRQF_ONESHOT is not needed - it is used for threaded interrupt > handlers, and this driver does not used a threaded interrupt handler. > So remove that setting. > > Signed-off-by: NeilBrown Reviewed-by:Chaotian Jing > --- > drivers/mmc/host/mtk-sd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 0798f0ba6d34..469d4a717175 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -2240,7 +2240,7 @@ static int msdc_drv_probe(struct platform_device *pdev) > msdc_init_hw(host); > > ret = devm_request_irq(&pdev->dev, host->irq, msdc_irq, > - IRQF_TRIGGER_LOW | IRQF_ONESHOT, pdev->name, host); > + IRQF_TRIGGER_NONE, pdev->name, host); > if (ret) > goto release; > > >