Re: [PATCH v3 5/7] nvme-pci: add device coredump infrastructure

Akinobu Mita
2019-05-13T15:01:20Z

2019年5月13日(月) 22:55 Keith Busch <kbusch@kernel.org>:
>
> On Sun, May 12, 2019 at 08:54:15AM -0700, Akinobu Mita wrote:
> > +static void nvme_coredump_logs(struct nvme_dev *dev)
> > +{
> > + struct dev_coredumpm_bulk_data *bulk_data;
> > +
> > + if (!dev->dumps)
> > + return;
> > +
> > + bulk_data = nvme_coredump_alloc(dev, 1);
> > + if (!bulk_data)
> > + return;
> > +
> > + if (nvme_coredump_telemetry_log(bulk_data, &dev->ctrl))
> > + dev->num_dumps--;
> > +}
>
> You'll need this function to return the same 'int' value from
> nvme_coredump_telemetry_log. A negative value here means that the
> device didn't produce a response, and that's important to check from
> the reset work since you'll need to abort the reset if that happens.

OK. Make sense.