Re: [PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout

Keith Busch
2019-05-13T13:57:59Z

On Sun, May 12, 2019 at 08:54:16AM -0700, Akinobu Mita wrote:
> @@ -2536,6 +2539,9 @@ static void nvme_reset_work(struct work_struct *work)
> if (result)
> goto out;
>
> + nvme_coredump_logs(dev);

If you change nvme_coredump_logs to return an int, check it here for < 0
and abandon the reset if true.

> + nvme_coredump_complete(dev);
> +
> if (dev->ctrl.oacs & NVME_CTRL_OACS_SEC_SUPP) {
> if (!dev->ctrl.opal_dev)
> dev->ctrl.opal_dev =