From: Viorel Suman <viorel.suman@nxp.com>
To: "festevam@gmail.com" <festevam@gmail.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"colin.king@canonical.com" <colin.king@canonical.com>,
"viorel.suman@gmail.com" <viorel.suman@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"S.j. Wang" <shengjiu.wang@nxp.com>,
"Julia.Lawall@lip6.fr" <Julia.Lawall@lip6.fr>,
Daniel Baluta <daniel.baluta@nxp.com>,
"perex@perex.cz" <perex@perex.cz>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: AK4458: add regulator for ak4458
Date: Thu, 16 May 2019 14:11:31 +0000 [thread overview]
Message-ID: <1558015890.29679.3.camel@nxp.com> (raw)
In-Reply-To: <CAOMZO5C1jm=7tiui221B-N+ptEknK_ZdHvrjvSHfvQ=W-K54Qw@mail.gmail.com>
On Jo, 2019-05-16 at 10:14 -0300, Fabio Estevam wrote:
> On Thu, May 16, 2019 at 10:02 AM Viorel Suman <viorel.suman@nxp.com> wrote:
>
> >
> > + for (i = 0; i < ARRAY_SIZE(ak4458->supplies); i++)
> > + ak4458->supplies[i].supply = ak4458_supply_names[i];
> > +
> > + ret = devm_regulator_bulk_get(ak4458->dev, ARRAY_SIZE(ak4458->supplies),
> > + ak4458->supplies);
> > + if (ret != 0) {
> > + dev_err(ak4458->dev, "Failed to request supplies: %d\n", ret);
> > + return ret;
> This would break existing users that do not pass the regulators in device tree.
>
> Ok, in this case there is no ak4458 user in any dts, so that would not
> be an issue.
>
> Please update the dt-bindings with the regulator entries.
Thanks, will send in V2.
/Viorel
next prev parent reply other threads:[~2019-05-16 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 13:00 [PATCH] ASoC: AK4458: add regulator for ak4458 Viorel Suman
2019-05-16 13:14 ` [alsa-devel] " Fabio Estevam
2019-05-16 14:11 ` Viorel Suman [this message]
2019-05-16 16:54 ` Mark Brown
2019-05-16 14:16 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558015890.29679.3.camel@nxp.com \
--to=viorel.suman@nxp.com \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
--cc=viorel.suman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox