Re: [alsa-devel] [PATCH] ASoC: AK4458: add regulator for ak4458

Fabio Estevam
2019-05-16T13:14:56Z

On Thu, May 16, 2019 at 10:02 AM Viorel Suman <viorel.suman@nxp.com> wrote:

> + for (i = 0; i < ARRAY_SIZE(ak4458->supplies); i++)
> + ak4458->supplies[i].supply = ak4458_supply_names[i];
> +
> + ret = devm_regulator_bulk_get(ak4458->dev, ARRAY_SIZE(ak4458->supplies),
> + ak4458->supplies);
> + if (ret != 0) {
> + dev_err(ak4458->dev, "Failed to request supplies: %d\n", ret);
> + return ret;

This would break existing users that do not pass the regulators in device tree.

Ok, in this case there is no ak4458 user in any dts, so that would not
be an issue.

Please update the dt-bindings with the regulator entries.