From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 148A4C04AAF for ; Fri, 17 May 2019 01:43:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC80820848 for ; Fri, 17 May 2019 01:43:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726447AbfEQBnl (ORCPT ); Thu, 16 May 2019 21:43:41 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:26307 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725933AbfEQBnl (ORCPT ); Thu, 16 May 2019 21:43:41 -0400 X-UUID: 393b68ce217a4248a5a81dea35289d78-20190517 X-UUID: 393b68ce217a4248a5a81dea35289d78-20190517 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 64267315; Fri, 17 May 2019 09:43:33 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs02n2.mediatek.inc (172.21.101.101) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 17 May 2019 09:43:30 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 17 May 2019 09:43:30 +0800 Message-ID: <1558057410.14401.7.camel@mtksdaap41> Subject: Re: [PATCH v6 10/12] soc: mediatek: cmdq: add cmdq_dev_get_subsys function From: CK Hu To: Bibby Hsieh CC: Jassi Brar , Matthias Brugger , Rob Herring , Daniel Kurtz , Sascha Hauer , , , , , , Sascha Hauer , "Philipp Zabel" , Nicolas Boichat , "YT Shen" , Daoyuan Huang , Jiaguang Zhang , Dennis-YC Hsieh , Houlong Wei , Date: Fri, 17 May 2019 09:43:30 +0800 In-Reply-To: <20190516090224.59070-11-bibby.hsieh@mediatek.com> References: <20190516090224.59070-1-bibby.hsieh@mediatek.com> <20190516090224.59070-11-bibby.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-SNTS-SMTP: 3998765BEF12231DA372060CB9BFDD6D6C26BD1427123C3EADA0958FB374F4BB2000:8 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Bibby: On Thu, 2019-05-16 at 17:02 +0800, Bibby Hsieh wrote: > GCE cannot know the register base address, this function > can help cmdq client to get the relationship of subsys > and register base address. > > Signed-off-by: Bibby Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 25 +++++++++++++++++++++++++ > include/linux/soc/mediatek/mtk-cmdq.h | 18 ++++++++++++++++++ > 2 files changed, 43 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index a53cdd71cfc2..a64060a34e01 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -27,6 +27,31 @@ struct cmdq_instruction { > u8 op; > }; > > +struct cmdq_subsys *cmdq_dev_get_subsys(struct device *dev, int idx) > +{ > + struct cmdq_subsys *subsys; > + struct of_phandle_args spec; > + > + subsys = devm_kzalloc(dev, sizeof(*subsys), GFP_KERNEL); > + if (!subsys) > + return NULL; > + > + if (of_parse_phandle_with_args(dev->of_node, "mediatek,gce-client-reg", > + "#subsys-cells", idx, &spec)) { > + dev_err(dev, "can't parse gce-client-reg property"); print the idx info. > + I think you should free the buffer you allocate. Don't expect this function is called in caller's probe function. > + return (struct cmdq_subsys *)-ENODEV; Why not return NULL? > + } > + > + subsys->id = spec.args[0]; > + subsys->offset = spec.args[1]; > + subsys->size = spec.args[2]; > + of_node_put(spec.np); > + > + return subsys; > +} > +EXPORT_SYMBOL(cmdq_dev_get_subsys); > + > static void cmdq_client_timeout(struct timer_list *t) > { > struct cmdq_client *client = from_timer(client, t, timer); > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > index 0651a0bffa54..574006c5cd76 100644 > --- a/include/linux/soc/mediatek/mtk-cmdq.h > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > @@ -15,6 +15,12 @@ > > struct cmdq_pkt; > > +struct cmdq_subsys { May be cmdq_client_reg. > + u8 id; May be subsys. Regards, CK > + u16 offset; > + u16 size; > +}; > + > struct cmdq_client { > spinlock_t lock; > u32 pkt_cnt; > @@ -142,4 +148,16 @@ int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb cb, > */ > int cmdq_pkt_flush(struct cmdq_pkt *pkt); > > +/** > + * cmdq_dev_get_subsys() - parse sub system from the device node of CMDQ client > + * @dev: device of CMDQ mailbox client > + * @idx: the index of desired subsys > + * > + * Return: CMDQ subsys pointer > + * > + * Help CMDQ client pasing the sub system number > + * from the device node of CMDQ client. > + */ > +struct cmdq_subsys *cmdq_dev_get_subsys(struct device *dev, int idx); > + > #endif /* __MTK_CMDQ_H__ */