Re: [PATCH v3 1/8] dt-bindings: soc: Add Aspeed XDMA engine binding documentation

Andrew Jeffery
2019-05-30T05:30:31Z

On Thu, 30 May 2019, at 03:40, Eddie James wrote:
> Document the bindings.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> .../devicetree/bindings/soc/aspeed/xdma.txt | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/aspeed/xdma.txt
>
> diff --git a/Documentation/devicetree/bindings/soc/aspeed/xdma.txt
> b/Documentation/devicetree/bindings/soc/aspeed/xdma.txt
> new file mode 100644
> index 0000000..85e82ea
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/aspeed/xdma.txt
> @@ -0,0 +1,23 @@
> +* Device tree bindings for the Aspeed XDMA Engine
> +
> +The XDMA Engine embedded in the AST2500 SOC can perform automatic DMA
> +operations over PCI between the AST2500 (acting as a BMC) and a host
> processor.
> +
> +Required properties:
> +
> + - compatible "aspeed,ast2500-xdma"
> + - reg contains the offset and length of the memory region
> + assigned to the XDMA registers
> + - resets reset specifier for the syscon reset associated with
> + the XDMA engine
> + - interrupts the interrupt associated with the XDMA engine on this
> + platform

The indentation is quite distracting. If you rev the series can you fix it?

Otherwise,

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>

> +
> +Example:
> +
> + xdma@1e6e7000 {
> + compatible = "aspeed,ast2500-xdma";
> + reg = <0x1e6e7000 0x100>;
> + resets = <&syscon ASPEED_RESET_XDMA>;
> + interrupts = <6>;
> + };
> --
> 1.8.3.1
>
>